-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adpone: onBidWon implementation #3801
adpone: onBidWon implementation #3801
Conversation
@seergiioo6 Hello thanks, I want to test this but the current test parameters given in the Actually I get a CORS issue when a request is made to the https://rtb.adpone.com/bid-request?pid=1234 endpoint. Can you please help me configure my test parameters to return bids from the adpone endpoint and allow a full e2e test? |
Hi @robertrmartinez! I've created a placementId for testing purposes: 11946231713535. Are you sending requests from a browser? Our endpoint is only accessible from browsers. That could be the reason you are not getting a valid bid response... TY! |
Thanks for providing the placementId However it returns a 0 price bid. Technically every adapter is supposed to have constant valid params which always return valid test bids. Can use But your adapter filters out your |
@seergiioo6 As it is not part of this PR I will not reject it for not returning a valid bid. But as for the bidWon event URL I got it to fire but it returns a 404 every time. Is there certain things that need to happen? |
Hi @robertrmartinez! you're right! Our adapter filters out bids if the CPM is not > 0. Now 11946231713535 returns a valid CPM. On the other hand. We've already fixed the 404 error that you were getting. Thank you very much. |
Thank you @seergiioo6. I do get a Otherwise LGTM will merge. If it is possible, please update your adapter markdown to contain this placement ID into another PR as soon as possible so future users / reviewers can use it when testing your adapter. |
Type of change
Description of change
Adpone bid adapter onBidWon implementation
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information