Rad 2751/specify ad units set targeting for ast #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 30, 2019 14:42
…-2751/specify-adUnits-setTargetingForAST
…-2751/specify-adUnits-setTargetingForAST
jaiminpanchal27
requested changes
May 7, 2019
| targetingInstance.setTargetingForAst(adUnitCodes); | ||
| expect(targetingInstance.getAllTargeting.called).to.equal(true); | ||
| expect(targetingInstance.resetPresetTargetingAST.called).to.equal(true); | ||
| expect(window.apntag.setKeywords.called).to.equal(true); |
There was a problem hiding this comment.
To differentiate between this test and the one with single adUnitCode, you should test here that window.apntag.setKeywords executed twice. Also another assertion can be called with args. Check this sinonjs/sinon#953 (comment)
There was a problem hiding this comment.
updated the tests.
|
|
||
| function mockGetAllTargeting(adUnitCodes) { | ||
| adUnitCodes = Array.isArray(adUnitCodes) ? adUnitCodes : Array(adUnitCodes); | ||
| sandbox.stub(targetingInstance, 'getAllTargeting').callsFake(function() { |
There was a problem hiding this comment.
I would suggest here to use stub.returns. Changing the implementation of getAllTargeting with this fake function is not a good idea. So you can do something like below in each test case
targetingStub.returns({
'adUnitCode': {hb_bidder:'appnexus'}
});
added 2 commits
May 10, 2019 14:37
This reverts commit 1a89d02.
jsnellbaker
approved these changes
May 10, 2019
jaiminpanchal27
approved these changes
May 10, 2019
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
May 13, 2019
* add adUnitCodes as param for setTargetingForAst() * unit tests for setTargetingForAst * refactor * Revert "refactor" This reverts commit 1a89d02. * refactor to add more tests
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* add adUnitCodes as param for setTargetingForAst() * unit tests for setTargetingForAst * refactor * Revert "refactor" This reverts commit 1a89d02. * refactor to add more tests
|
Docs PR: prebid/prebid.github.io#1357 |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* add adUnitCodes as param for setTargetingForAst() * unit tests for setTargetingForAst * refactor * Revert "refactor" This reverts commit 1a89d02. * refactor to add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added Unit tests for setTargetingForAst()
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: