Reload Adapter: New #3812

mafernandez80 · 2019-05-09T14:11:46Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

bidder: 'reload',
params: {
        plcmID: "prebid_check",
        partID: "part_4",
        opdomID: "0",
        bsrvID: 0
    }

contact email of the adapter’s maintainer: prebid@reload.net
official adapter submission
DOC: A link to a PR #1304

jaiminpanchal27

@mafernandez80 Needs some changes before we can merge your adapter. Please address comments

jaiminpanchal27 · 2019-05-14T15:04:46Z

modules/reloadBidAdapter.js

+
+export const spec = {
+  code: BIDDER_CODE,
+  aliases: [],


Please remove aliases property if you are not creating any alias

jaiminpanchal27 · 2019-05-14T15:05:54Z

modules/reloadBidAdapter.js

+export const spec = {
+  code: BIDDER_CODE,
+  aliases: [],
+  supportedMediaTypes: [BANNER],


Banner is default format. Please remove supportedMediaTypes property if you are only supporting banner

jaiminpanchal27 · 2019-05-14T15:06:45Z

modules/reloadBidAdapter.js

+   */
+  buildRequests: function (validBidRequests, bidderRequest) {
+
+    var vRequests = [];


Use let/const where applicable. We recommend using ES6. Please update at other places as well

jaiminpanchal27 · 2019-05-14T15:07:43Z

modules/reloadBidAdapter.js

+   * @param {ServerResponse[]} serverResponses List of server's responses.
+   * @return {UserSync[]} The user syncs which should be dropped.
+   */
+  getUserSyncs: function (syncOptions, serverResponses) {


Please remove if you are not using getUserSyncs

jaiminpanchal27 · 2019-05-14T15:07:51Z

modules/reloadBidAdapter.js

+   * Register bidder specific code, which will execute if bidder timed out after an auction
+   * @param {data} Containing timeout specific data
+   */
+  onTimeout: function (data) {},


Please remove if you are not using onTimeout

jaiminpanchal27 · 2019-05-14T15:08:10Z

modules/reloadBidAdapter.js

+   * Register bidder specific code, which will execute if a bid from this bidder won the auction
+   * @param {Bid} The bid that won the auction
+   */
+  onBidWon: function (bid) {},


Please remove if you are not using onBidWon

jaiminpanchal27 · 2019-05-14T15:08:22Z

modules/reloadBidAdapter.js

+   */
+  onBidWon: function (bid) {},
+
+  onSetTargeting: function (bid) {}


Please remove if you are not using onSetTargeting

jaiminpanchal27 · 2019-05-14T15:08:45Z

modules/reloadBidAdapter.js

+ * @param {json} args
+ */
+
+function ReloadClientTool(args) {


What does this function do ?

It's a class constructor. It is used to instantiate an interface class that we must use to have a single standard across all our adapters/drivers.

jaiminpanchal27 · 2019-05-14T15:09:09Z

modules/reloadBidAdapter.js

+
+  var that = this;
+
+


Lot of unnecessary line breaks throughout the file. Please remove them

jaiminpanchal27 · 2019-05-14T15:11:46Z

test/spec/modules/reloadBidAdapter_spec.js

@@ -0,0 +1,300 @@
+import { expect } from 'chai';
+import { spec } from 'modules/reloadBidAdapter';
+import { newBidder } from 'src/adapters/bidderFactory';


Remove unused imports. Following are not used in your test file anywhere

import { newBidder } from 'src/adapters/bidderFactory'; import * as bidderFactory from 'src/adapters/bidderFactory'; import { deepClone } from 'src/utils'; import { config } from 'src/config';

jaiminpanchal27 · 2019-05-14T17:54:22Z

@mafernandez80 Circleci failed due to lint errors. You can fix and check on local by running gulp lint

mafernandez80 · 2019-05-14T18:25:02Z

@jaiminpanchal27 I executed your command but lint ran ok.
Steps:
1.- Clone repository
2.- npm install
3.- copied our adapter & spec
4.- gulp lint

jaiminpanchal27 · 2019-05-14T18:30:51Z

Yes, same happened for me too. Actually on running gulp lint, it autofixex the files. So if you now do git status, it will show you changes to commit.
To ignore autofixes run gulp lint --nolintfix

mafernandez80 · 2019-05-14T18:56:39Z

@jaiminpanchal27 I fixed all lint errors

mafernandez80 · 2019-05-14T20:09:04Z

@jaiminpanchal27 I see that there is a new release but our adapter has not been included. Is there anything still to be fixed? We really need this ASAP to start our tests. Thnx!

jaiminpanchal27 · 2019-05-14T20:18:46Z

@mafernandez80 We release every Tuesday. It will be included in next release. I understand your urgency but one of my colleague had already started work on the release since morning.

I will test your params on hello world page and let you know if anything more is needed. Code looks good.

jaiminpanchal27 · 2019-05-15T15:07:57Z

@mafernandez80 I am not getting valid bid back from your adapter. Here is the response from your endpoint. I used the params given in reloadBidAdapter.md file on Prebid hello_world page.

{"id":"5355660366943247","bidid":"fbs-br-d3jbibjgjvpcy1fs","seatbid":[{"bid":[{"id":"fbs-br-stbd-bd-d3jbibjgjvpcy1fu","impid":"2e4c0d6ff12ee4","crid":"2e4c0d6ff12ee4","price":0,"nurl":"","adm":"","ext":{"pcmdata":{},"error":{"msg":"Cannot read property 'fireEvent' of undefined","stack":"TypeError: Cannot read property 'fireEvent' of undefined\n    at fireUnderFilterString_Algo (/bidserver/BidServer/lib/proxy/v2.25/pcm_bundle.js:6323:26)\n    at fireUnderFilterString (/bidserver/BidServer/lib/proxy/v2.25/pcm_bundle.js:6319:9)\n    at _fireEventX (/bidserver/BidServer/lib/proxy/v2.25/pcm_bundle.js:6315:7)\n    at _fireEvent (/bidserver/BidServer/lib/proxy/v2.25/pcm_bundle.js:6329:7)\n    at _fb_PCM (/bidserver/BidServer/lib/proxy/v2.25/pcm_bundle.js:5891:5)\n    at _makePCMCall (/bidserver/BidServer/lib/engine/pcmengine.js:255:16)\n    at Object.callback (/bidserver/BidServer/lib/engine/pcmengine.js:99:15)\n    at Client.memcached.delegateCallback (/bidserver/BidServer/node_modules/memcached/lib/memcached.js:687:12)\n    at Client.rawDataReceived (/bidserver/BidServer/node_modules/memcached/lib/memcached.js:758:22)\n    at Client.BufferBuffer (/bidserver/BidServer/node_modules/memcached/lib/memcached.js:678:12)\n    at Socket.bowlofcurry (/bidserver/BidServer/node_modules/memcached/lib/utils.js:126:15)\n    at Socket.emit (events.js:193:13)\n    at Socket.EventEmitter.emit (domain.js:481:20)\n    at addChunk (_stream_readable.js:295:12)\n    at readableAddChunk (_stream_readable.js:272:13)\n    at Socket.Readable.push (_stream_readable.js:231:10)\n    at TCP.onStreamRead (internal/stream_base_commons.js:150:17)"},"plcmID":"4234897234","partID":"part_2","opdomID":0,"bsrvID":0,"banner":{"w":300,"h":250}}}],"seat":"fbs-br-stbd-d3jbibjgjvpcy1ft","group":0}]}

mafernandez80 · 2019-05-15T15:22:20Z

@jaiminpanchal27 I pasted test parameters when I created this pull request:
...
bidder: 'reload',
params: {
plcmID: "prebid_check",
partID: "part_4",
opdomID: "0",
bsrvID: 0
}
...

jaiminpanchal27

LGTM.

jaiminpanchal27 · 2019-05-15T15:33:03Z

Verified bids back with the params provided in PR description. Please update your test params in reloadBidAdapter.md file so I can merge your adapter.

mafernandez80 · 2019-05-15T16:03:51Z

@jaiminpanchal27 I updated test params with PR test.

* Reload Adapter: New * Reload Adapter - Spec * Reload Adapter and Spec - Changes according comments * Reload Adapter & Spec: lint errors fixed * Reload Adapter: Example updated

Mariano A. Fernández added 2 commits May 9, 2019 10:57

Reload Adapter: New

2a036fe

Reload Adapter - Spec

58dad72

jsnellbaker requested a review from jaiminpanchal27 May 13, 2019 13:00

jsnellbaker assigned jaiminpanchal27 May 13, 2019

jaiminpanchal27 requested changes May 14, 2019

View reviewed changes

jaiminpanchal27 added needs update needs docs labels May 14, 2019

Reload Adapter and Spec - Changes according comments

9bbefbe

Reload Adapter & Spec: lint errors fixed

23050b7

jaiminpanchal27 approved these changes May 15, 2019

View reviewed changes

jaiminpanchal27 removed needs docs needs update labels May 15, 2019

Reload Adapter: Example updated

fa4dbe8

jaiminpanchal27 merged commit 3b9f9e1 into prebid:master May 15, 2019

mafernandez80 mentioned this pull request Jul 11, 2019

Reload Adapter & Spec: Added GDPR and multiple sizes #3967

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reload Adapter: New #3812

Reload Adapter: New #3812

mafernandez80 commented May 9, 2019

jaiminpanchal27 left a comment

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 May 14, 2019

mafernandez80 May 14, 2019

jaiminpanchal27 commented May 14, 2019

mafernandez80 commented May 14, 2019

jaiminpanchal27 commented May 14, 2019

mafernandez80 commented May 14, 2019

mafernandez80 commented May 14, 2019

jaiminpanchal27 commented May 14, 2019

jaiminpanchal27 commented May 15, 2019

mafernandez80 commented May 15, 2019

jaiminpanchal27 left a comment

jaiminpanchal27 commented May 15, 2019

mafernandez80 commented May 15, 2019

Reload Adapter: New #3812

Reload Adapter: New #3812

Conversation

mafernandez80 commented May 9, 2019

Type of change

Description of change

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaiminpanchal27 commented May 14, 2019

mafernandez80 commented May 14, 2019

jaiminpanchal27 commented May 14, 2019

mafernandez80 commented May 14, 2019

mafernandez80 commented May 14, 2019

jaiminpanchal27 commented May 14, 2019

jaiminpanchal27 commented May 15, 2019

mafernandez80 commented May 15, 2019

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

jaiminpanchal27 commented May 15, 2019

mafernandez80 commented May 15, 2019