update fun-hooks and use no-eval version for CSP #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
approved these changes
May 13, 2019
jsnellbaker
added
needs 2nd review
jsnellbaker
assigned idettman, jaiminpanchal27 and robertrmartinez and unassigned jsnellbaker
idettman
approved these changes
May 13, 2019
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* update fun-hooks and use no-eval version for CSP * update fun-hooks to version with proper assign for ie
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* update fun-hooks and use no-eval version for CSP * update fun-hooks to version with proper assign for ie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
I've updated the fun-hooks library to spit out two versions, one that uses
new Function(with better performance) and one that does not but is strict content security policy compliant. This updates Prebid.js to use the CSP compliant one to allow Prebid.js to run on sites with strict CSP.Other information
Related to #3590