Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPMStar Bid Adapter #3820

Merged
merged 5 commits into from
May 21, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved cpmstarBidAdapter code coverage
  • Loading branch information
JoshuaMGoldstein committed May 11, 2019
commit 80209231d9d605d646b6be80ad76e81ec44fda4f
33 changes: 17 additions & 16 deletions modules/cpmstarBidAdapter.js
Original file line number Diff line number Diff line change
@@ -11,23 +11,24 @@ const ENDPOINT_PRODUCTION = '//server.cpmstar.com/view.aspx';
const DEFAULT_TTL = 300;
const DEFAULT_CURRENCY = 'USD';

function getMediaType(bidRequest) {
if (bidRequest == null) return BANNER;
return !utils.deepAccess(bidRequest, 'mediaTypes.video') ? BANNER : VIDEO;
}

function getPlayerSize(bidRequest) {
var playerSize = utils.deepAccess(bidRequest, 'mediaTypes.video.playerSize');
if (playerSize[0] != null) playerSize = playerSize[0];
if (playerSize == null || playerSize[0] == null || playerSize[1] == null) return [640, 440];
return playerSize;
}

export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [BANNER, VIDEO],
pageID: Math.floor(Math.random() * 10e6),

getMediaType: function(bidRequest) {
if (bidRequest == null) return BANNER;
return !utils.deepAccess(bidRequest, 'mediaTypes.video') ? BANNER : VIDEO;
},

getPlayerSize: function(bidRequest) {
var playerSize = utils.deepAccess(bidRequest, 'mediaTypes.video.playerSize');
if (playerSize == null) return [640, 440];
if (playerSize[0] != null) playerSize = playerSize[0];
if (playerSize == null || playerSize[0] == null || playerSize[1] == null) return [640, 440];
return playerSize;
},

isBidRequestValid: function (bid) {
return ((typeof bid.params.placementId === 'string') && !!bid.params.placementId.length) || (typeof bid.params.placementId === 'number');
},
@@ -41,8 +42,8 @@ export const spec = {
var referer = encodeURIComponent(bidderRequest.refererInfo.referer);
var e = utils.getBidIdParameter('endpoint', bidRequest.params);
var ENDPOINT = e == 'dev' ? ENDPOINT_DEV : e == 'staging' ? ENDPOINT_STAGING : ENDPOINT_PRODUCTION;
var mediaType = getMediaType(bidRequest);
var playerSize = getPlayerSize(bidRequest);
var mediaType = spec.getMediaType(bidRequest);
var playerSize = spec.getPlayerSize(bidRequest);
var videoArgs = '&fv=0' + (playerSize ? ('&w=' + playerSize[0] + '&h=' + playerSize[1]) : '');
requests.push({
method: 'GET',
@@ -61,7 +62,7 @@ export const spec = {

interpretResponse: function (serverResponse, request) {
var bidRequest = request.bidRequest;
var mediaType = getMediaType(bidRequest);
var mediaType = spec.getMediaType(bidRequest);

var bidResponses = [];

@@ -100,7 +101,7 @@ export const spec = {
if (mediaType == BANNER && rawBid.code) {
bidResponse.ad = rawBid.code + (rawBid.px_cr ? "\n<img width=0 height=0 src='" + rawBid.px_cr + "' />" : '');
} else if (mediaType == VIDEO && rawBid.creativemacros && rawBid.creativemacros.HTML5VID_VASTSTRING) {
var playerSize = getPlayerSize(bidRequest);
var playerSize = spec.getPlayerSize(bidRequest);
if (playerSize != null) {
bidResponse.width = playerSize[0];
bidResponse.height = playerSize[1];
20 changes: 20 additions & 0 deletions test/spec/modules/cpmstarBidAdapter_spec.js
Original file line number Diff line number Diff line change
@@ -14,6 +14,26 @@ describe('Cpmstar Bid Adapter', function () {
var bid = { params: { placementId: '' } };
expect(spec.isBidRequestValid(bid)).to.equal(false);
})

it('should return a valid player size', function() {
var bid = { mediaTypes: {
video: {
playerSize: [[960, 540]]
}
}}
expect(spec.getPlayerSize(bid)[0]).to.equal(960);
expect(spec.getPlayerSize(bid)[1]).to.equal(540);
})

it('should return a default player size', function() {
var bid = { mediaTypes: {
video: {
playerSize: null
}
}}
expect(spec.getPlayerSize(bid)[0]).to.equal(640);
expect(spec.getPlayerSize(bid)[1]).to.equal(440);
})
});

describe('buildRequests', function () {