Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3813 move auctionEnd events so it always executes when auction completes #3841

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fixes #3813.

This change was made primarily to ensure that the auctionEnd event will always trigger even if the publisher didn't include a bidsBackHandler when making the pbjs.requestBids() call (as found while looking into the above issue).

This change also ensures other actions taken after the auction finishes are always executed (such as calling timed out bidders, firing userSyncs, and changing the auctionStatus).

@jsnellbaker jsnellbaker added needs review needs 2nd review Core module updates require two approvals from the core team labels May 20, 2019
@stale
Copy link

stale bot commented Jun 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2019
@jsnellbaker jsnellbaker removed the stale label Jun 3, 2019
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @jsnellbaker

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 6e7eb3b into master Jun 18, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
…tion completes (prebid#3841)

* move auctionEnd events so it always executes

* remove some commented code
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
…tion completes (prebid#3841)

* move auctionEnd events so it always executes

* remove some commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate auction end event not emitting without specifying timeout
4 participants