-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding aliases for adsparc and safereach to aardvark adapter #3848
Conversation
Adding aliases for adsparc and safereach
Update aardvark adapter
adsparc is already an alias of serverbid: Prebid.js/modules/serverbidBidAdapter.js Line 19 in 96aae26
So this alias either needs a different name or the alias needs to be removed from ServerBid. To remove it from ServerBid, I'd need some confirmation from someone at adsparc that removing it from ServerBid and adding it Aardvark is what they want to do. |
hey @mike-chowla - @sanjayamolligoda from adsparc tried to comment on this thread but it says he cannot. Any ideas? |
usually that means you have an adblocker installed. |
Hi Mike, I'd like to confirm this request to move adsparc's alias from serverbid to aardvark. Cheers
|
Per request of @sanjayamolligoda at adsparc. Removing alias from serverbid.
@mike-chowla @mkendall07 hey guys I think we're all set here. let me know what else would be needed. |
…3848) * Update aardvark adapter Adding aliases for adsparc and safereach * Update aardvarkBidAdapter.js * Removing adsparc from serverbid adapters Per request of @sanjayamolligoda at adsparc. Removing alias from serverbid.
Adding aliases for adsparc and safereach
Type of change
Description of change
Adding aliases for adsparc and safereach
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: