Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding aliases for adsparc and safereach to aardvark adapter #3848

Merged
merged 4 commits into from
Jun 10, 2019

Conversation

naegelin
Copy link
Contributor

Adding aliases for adsparc and safereach

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Adding aliases for adsparc and safereach

  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@mike-chowla
Copy link
Contributor

adsparc is already an alias of serverbid:

So this alias either needs a different name or the alias needs to be removed from ServerBid. To remove it from ServerBid, I'd need some confirmation from someone at adsparc that removing it from ServerBid and adding it Aardvark is what they want to do.

@naegelin
Copy link
Contributor Author

naegelin commented Jun 4, 2019

hey @mike-chowla - @sanjayamolligoda from adsparc tried to comment on this thread but it says he cannot. Any ideas?

@mkendall07
Copy link
Member

usually that means you have an adblocker installed.

@sanjayamolligoda
Copy link

Hi Mike,

I'd like to confirm this request to move adsparc's alias from serverbid to aardvark.

Cheers
Sanjaya

adsparc is already an alias of serverbid:

So this alias either needs a different name or the alias needs to be removed from ServerBid. To remove it from ServerBid, I'd need some confirmation from someone at adsparc that removing it from ServerBid and adding it Aardvark is what they want to do.

Per request of @sanjayamolligoda at adsparc. Removing alias from serverbid.
@naegelin
Copy link
Contributor Author

naegelin commented Jun 7, 2019

@mike-chowla @mkendall07 hey guys I think we're all set here. let me know what else would be needed.

@mike-chowla mike-chowla merged commit cacb6e7 into prebid:master Jun 10, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
…3848)

* Update aardvark adapter 

Adding aliases for adsparc and safereach

* Update aardvarkBidAdapter.js

* Removing adsparc from serverbid adapters

Per request of @sanjayamolligoda at adsparc. Removing alias from serverbid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants