Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rtbhouseBidAdapter.md #3857

Merged
merged 1 commit into from
May 27, 2019
Merged

Update rtbhouseBidAdapter.md #3857

merged 1 commit into from
May 27, 2019

Conversation

Kamoris
Copy link
Contributor

@Kamoris Kamoris commented May 23, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Explicit native.image.sizes in doc

Other information

@piwanczak

@Kamoris
Update rtbhouseBidAdapter.md
63e79ae 
Explicit native.image.sizes in doc
@Kamoris Kamoris closed this May 23, 2019
@Kamoris Kamoris reopened this May 23, 2019
@Kamoris Kamoris marked this pull request as ready for review May 24, 2019 06:09
mike-chowla
mike-chowla approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla
Copy link
Contributor

CircleCI failed on this but I don't see how that could be related to a change of an md file so merging anyway

@mike-chowla mike-chowla merged commit d7af6db into prebid:master May 27, 2019
@Kamoris
Copy link
Contributor Author

Kamoris commented May 28, 2019

Thank you!

@Kamoris Kamoris deleted the patch-2 branch May 28, 2019 05:51
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@Kamoris
Update rtbhouseBidAdapter.md (prebid#3857)
6cfd669 
Explicit native.image.sizes in doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kamoris @mike-chowla