-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bid adapter for seedtag #3915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cabama,
Thanks for submitting your adaptor. You need to pass vastUrl
in the bid object in your adaptor file like this vastUrl: rtbBid.rtb.video.asset_url
. vastUrl
is a mandatory field for instream
videos. Please refer appnexusBidAdapter.js for more info.
From what we have seen in the response documentation our understanding was that vastUrl is not mandatory if the vastXml field is returned. Is this still the case or is vastUrl required? |
It seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.
* Added bid adapter for seedtag * Revert changes to package-lock * added safe check
* Added bid adapter for seedtag * Revert changes to package-lock * added safe check
Type of change
Description of change
Adding new bid adapter for seedtag
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Link to docs PR
Other information