Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove on set targeting #3919

Merged
merged 46 commits into from
Jun 18, 2019
Merged

Feature/remove on set targeting #3919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
afdf755
initial orbidder version in personal github repo
hendrikiseke1979 Jan 9, 2019
ffc6f0b
use adUnits from orbidder_example.html
hendrikiseke1979 Jan 9, 2019
5c9a947
replace obsolete functions
hendrikiseke1979 Jan 10, 2019
06d127e
forgot to commit the test
hendrikiseke1979 Jan 10, 2019
8617515
check if bidderRequest object is available
hendrikiseke1979 Jan 10, 2019
8b5c884
try to fix weird safari/ie issue
hendrikiseke1979 Jan 10, 2019
4eace10
Merge remote-tracking branch 'upstream/master'
hendrikiseke1979 Jan 14, 2019
8d9dd6f
merge changes from upstream
hendrikiseke1979 Jan 16, 2019
699d05d
fetch changes from upstream
hendrikiseke1979 Jan 17, 2019
367b1a7
ebayK: add more params
hendrikiseke1979 Jan 18, 2019
cfe0911
update orbidderBidAdapter.md
hendrikiseke1979 Jan 18, 2019
4279c11
use spec.<function> instead of this.<function> for consistency reasons
hendrikiseke1979 Jan 21, 2019
5625d93
fetch changes from upstream
hendrikiseke1979 Jan 21, 2019
67dc263
Merge branch 'feature/RAAS-2676'
hendrikiseke1979 Jan 21, 2019
89fb80b
fetch changes from upstream
hendrikiseke1979 Jan 24, 2019
ab665e9
fetch changes from upstream
hendrikiseke1979 Jan 28, 2019
b91d68d
fetch changes from upstream
Feb 1, 2019
393b3fe
fetch changes from upstream
Feb 15, 2019
d0b0cbc
fetch changes from upstream
hendrikiseke1979 Mar 5, 2019
5967f6e
fetch changes from upstream
hendrikiseke1979 Mar 6, 2019
df95b81
fetch changes from upstream
hendrikiseke1979 Mar 13, 2019
6169ec7
fetch changes from upstream
Mar 15, 2019
b05496f
add bidfloor parameter to params object
Mar 15, 2019
5a3d816
fetch changes from upstream
Mar 15, 2019
4c95866
fetch changes from upstream
hendrikiseke1979 Apr 2, 2019
e27e3dd
fetch changes from upstream
hendrikiseke1979 Apr 3, 2019
1470e8e
fetch changes from upstream
hendrikiseke1979 Apr 16, 2019
476c431
fix gdpr object handling
hendrikiseke1979 Apr 16, 2019
ff62c25
fetch changes from upstream
hendrikiseke1979 Apr 17, 2019
e011950
fetch changes from upstream
hendrikiseke1979 Apr 24, 2019
ba295b6
fetch changes from upstream
hendrikiseke1979 Apr 29, 2019
605fb7f
fetch changes from upstream
hendrikiseke1979 May 2, 2019
91d90fc
fetch changes from upstream
May 6, 2019
415af96
fetch changes from upstream
hendrikiseke1979 May 7, 2019
8906bcd
Merge branch 'master' of github.com:hiseke/Prebid.js
hendrikiseke1979 May 7, 2019
da8dbde
default to consentRequired: false when not explicitly given
hendrikiseke1979 May 7, 2019
07c805c
wip - use onSetTargeting callback
mathiasmethner0815 May 7, 2019
86664b5
add tests for onSetTargeting callback
mathiasmethner0815 May 7, 2019
0664e97
fix params and respective tests
RainerVolk4014 May 8, 2019
d11fca0
Merge pull request #2 from hiseke/feature/fix-params-onSetTargeting
May 8, 2019
cbcb311
fetch changes from upstream
hendrikiseke1979 May 8, 2019
b17d19b
Merge branch 'master' of github.com:hiseke/Prebid.js
hendrikiseke1979 May 8, 2019
a102857
fetch changes from upstream
udojuettner6667 May 15, 2019
534cf58
fetch changes from upstream
hendrikiseke1979 May 16, 2019
9869782
fetch changes from upstream
udojuettner6667 Jun 14, 2019
b272bca
Remove onSetTargeting
udojuettner6667 Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/orbidderBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ export const spec = {
this.onHandler(bid, '/win');
},

onSetTargeting (bid) {
this.onHandler(bid, '/targeting');
},

onHandler (bid, route) {
const getRefererInfo = detectReferer(window);

Expand Down
6 changes: 0 additions & 6 deletions test/spec/modules/orbidderBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,6 @@ describe('orbidderBidAdapter', () => {
expect(ajaxStub.firstCall.args[0].indexOf('https://')).to.equal(0);
expect(ajaxStub.firstCall.args[0]).to.equal(`${spec.orbidderHost}/win`);
expect(ajaxStub.firstCall.args[1]).to.equal(JSON.stringify(bidObjClone));

spec.onSetTargeting(bidObj);
expect(ajaxStub.calledTwice).to.equal(true);
expect(ajaxStub.secondCall.args[0].indexOf('https://')).to.equal(0);
expect(ajaxStub.secondCall.args[0]).to.equal(`${spec.orbidderHost}/targeting`);
expect(ajaxStub.secondCall.args[1]).to.equal(JSON.stringify(bidObjClone));
});
});

Expand Down