Submodule system using hooks #3924

snapwich · 2019-06-18T19:30:49Z

Type of change

Bugfix

Description of change

Only include src dir and few node_modules inside of prebid-core bundle.

Other information

related to #3908

snapwich · 2019-06-19T21:03:01Z

Update the prebid-core hooks module with a module and submodule helper method which permits an install function for the parent module and the ability to pass data to the installer from the child module. This should allow for more sharing of functionality between child and parent modules without requiring either as static imports.

Also added the ./modules/.submodules.json to make the gulp bundler aware of these relationships. When using gulp build --modules=digiTrustIdSystem for example it will check the .submodules.json and see that digiTrust is a child of the userId module, so it will automatically include the parent module as well. Since they're using async hooks that are queued behind the scenes, load order of the modules doesn't matter.

idettman

Updated with userId submodule changes

jsnellbaker

LGTM

snapwich · 2019-06-24T18:02:29Z

it might be worthwhile including the required changes to freewheel and adpod in this pull-request as well so we aren't left with a partial fix in master for module issues: @jsnellbaker @jaiminpanchal27

jaiminpanchal27 · 2019-06-24T18:08:57Z

@snapwich I am starting that work today. I will update you as soon as it is done. Can I push to this branch or we create one new branch and create our PR's against that branch ?

snapwich · 2019-06-24T18:16:17Z

@jaiminpanchal27 you should be able to push to this branch, but a PR against this branch works as well. Whatever is easier for you guys!

…into prebid-core-bundle-fix # Conflicts: # modules/.submodules.json

jaiminpanchal27 · 2019-06-27T19:04:40Z

I have pushed adpod related changes. @jsnellbaker Please have a look and test
Added on hold label so we do not merge this without testing all prebid submodules.

snapwich · 2019-06-28T19:40:39Z

modules/.submodules.json

+    "pubCommonIdSystem",
+    "unifiedIdSystem",
+    "id5IdSystem",
+    "unifiedIdSystem"


I think someone handled a merge improperly here. Duplicate and removed modules are showing up now...

Might want to check to make sure no other changes were accidentally reverted as well.

Yeah this is supposed to be:

{ "userId": [ "digiTrustIdSystem", "id5IdSystem" ], "adpod": [ "freeWheelAdserverVideo" ] }

I checked the rest of the userId and it's releated files, and all look good. I'll commit a fix for the .submodules.json

* prebid-core only contains src and a few node_modules * add back removed neverBundle to webpack build * add module and submodule hooks * allow vargs for submodules for flexibility * fix jsdoc type syntax * updated id5 userid submodule for submodule bundle size duplication fix * add id5 userid submodule to .submodules * fix opt out logic * spelling fix to comment * update to automatically include 'pubcommon' and 'unifiedid' (uncomment to optional submodule for prebid3.0) * additional update to automatically include 'pubcommon' and 'unifiedid' * additional update to automatically include 'pubcommon' and 'unifiedid' * merged differences from master * adpod changes to support submodules * fix --modules argument with .json to work correctly with submodules * fix to remove included and duplicated submodules

prebid-core only contains src and a few node_modules

4b2a8f1

This comment has been minimized.

Sign in to view

snapwich and others added 2 commits June 18, 2019 13:43

add back removed neverBundle to webpack build

d036244

add module and submodule hooks

3cd6523

snapwich changed the title ~~prebid-core only contains src and a few node_modules~~ Submodule system using hooks Jun 19, 2019

snapwich mentioned this pull request Jun 19, 2019

remove pubCommonId import from emoteevBidAdapter #3932

Closed

1 task

jsnellbaker requested review from idettman, jsnellbaker, jaiminpanchal27 and robertrmartinez June 20, 2019 12:43

jsnellbaker assigned idettman, jsnellbaker, jaiminpanchal27 and robertrmartinez Jun 20, 2019

jsnellbaker added the needs review label Jun 20, 2019

allow vargs for submodules for flexibility

76cba02

idettman approved these changes Jun 20, 2019

View reviewed changes

idettman added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Jun 20, 2019

fix jsdoc type syntax

47d576e

jsnellbaker approved these changes Jun 24, 2019

View reviewed changes

idettman added on hold and removed needs 2nd review Core module updates require two approvals from the core team labels Jun 24, 2019

This comment has been minimized.

Sign in to view

Isaac Dettman added 2 commits June 24, 2019 11:36

Merge remote-tracking branch 'remote/master' into prebid-core-bundle-fix

f158c76

updated id5 userid submodule for submodule bundle size duplication fix

9c0620e

idettman added the needs 2nd review Core module updates require two approvals from the core team label Jun 27, 2019

idettman removed their request for review June 27, 2019 17:59

This comment has been minimized.

Sign in to view

Jaimin Panchal added 2 commits June 27, 2019 14:47

adpod changes to support submodules

73d6f5b

Merge branch 'prebid-core-bundle-fix' of github.com:prebid/Prebid.js …

4aa8550

…into prebid-core-bundle-fix # Conflicts: # modules/.submodules.json

jaiminpanchal27 added the on hold label Jun 27, 2019

fix --modules argument with .json to work correctly with submodules

058d448

snapwich commented Jun 28, 2019

View reviewed changes

fix to remove included and duplicated submodules

5d3e818

jsnellbaker self-requested a review July 1, 2019 18:18

jsnellbaker approved these changes Jul 1, 2019

View reviewed changes

jaiminpanchal27 approved these changes Jul 2, 2019

View reviewed changes

jaiminpanchal27 merged commit 113cfe9 into master Jul 2, 2019

idettman added LGTM and removed needs 2nd review Core module updates require two approvals from the core team on hold labels Jul 15, 2019

idettman removed the request for review from robertrmartinez July 19, 2019 18:22

pycnvr mentioned this pull request Jul 24, 2019

UserId - Add SameSite and server-side pubcid support #3869

Merged

10 tasks

idettman deleted the prebid-core-bundle-fix branch March 8, 2021 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Submodule system using hooks #3924

Submodule system using hooks #3924

snapwich commented Jun 18, 2019

This comment has been minimized.

snapwich commented Jun 19, 2019

idettman left a comment •

edited

Loading

jsnellbaker left a comment

This comment has been minimized.

snapwich commented Jun 24, 2019

jaiminpanchal27 commented Jun 24, 2019

snapwich commented Jun 24, 2019

This comment has been minimized.

jaiminpanchal27 commented Jun 27, 2019

snapwich Jun 28, 2019

idettman Jun 28, 2019 •

edited

Loading

Submodule system using hooks #3924

Submodule system using hooks #3924

Conversation

snapwich commented Jun 18, 2019

Type of change

Description of change

Other information

This comment has been minimized.

snapwich commented Jun 19, 2019

idettman left a comment • edited Loading

Choose a reason for hiding this comment

jsnellbaker left a comment

Choose a reason for hiding this comment

This comment has been minimized.

snapwich commented Jun 24, 2019

jaiminpanchal27 commented Jun 24, 2019

snapwich commented Jun 24, 2019

This comment has been minimized.

jaiminpanchal27 commented Jun 27, 2019

snapwich Jun 28, 2019

Choose a reason for hiding this comment

idettman Jun 28, 2019 • edited Loading

Choose a reason for hiding this comment

idettman left a comment •

edited

Loading

idettman Jun 28, 2019 •

edited

Loading