Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized COPPA support #3936

Merged
merged 15 commits into from
Jun 25, 2019
Merged

Conversation

msm0504
Copy link
Contributor

@msm0504 msm0504 commented Jun 20, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Support coppa flag being set in Prebid config and then sent to OpenRTB and individual adapter APIs
#3852

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg bretg changed the title Rubicon support coppa Standardized COPPA support Jun 21, 2019
@bretg bretg requested a review from robertrmartinez June 21, 2019 01:48
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msm0504 These changes look good from my perspective.

Could you add a (or some) unit test(s) to the new utils function?

Thanks!

@msm0504
Copy link
Contributor Author

msm0504 commented Jun 24, 2019

@jsnellbaker I've added unit tests for the utils function, but now tests for widespaceBidAdapter are failing on CircleCI. Tests pass when I run locally. Do you know what would cause this?

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msm0504 I think that test run was just a fluke. It's passing now on the subsequent test run.

LGTM

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs unit tests labels Jun 24, 2019
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Love the new deepSetValue util being added. Thanks!

@bretg
Copy link
Collaborator

bretg commented Jun 25, 2019

Docs PR prebid/prebid.github.io#1367

@bretg bretg removed needs 2nd review Core module updates require two approvals from the core team needs docs labels Jun 25, 2019
@msm0504
Copy link
Contributor Author

msm0504 commented Jun 25, 2019

@robertrmartinez Thank @idettman. He wrote the util. I copied it for my PR.

Also, I'm going to post in the slack channel about using a library for these types of utils. I asked about lodash previously, but that's too large. I found the clone function in Prebid is pulled from just (https://anguscroll.com/just/). I'm hoping we can use that for other functions, too.

@bretg bretg merged commit 64a258a into prebid:master Jun 25, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* Send coppa flag on requests to OpenRTB from Prebid server

* Support coppa flag being set in Prebid config

* Add unit tests for deepSetValue util function
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* Send coppa flag on requests to OpenRTB from Prebid server

* Support coppa flag being set in Prebid config

* Add unit tests for deepSetValue util function
@robertrmartinez robertrmartinez deleted the rubicon-support-coppa branch July 5, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants