Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsePoint adapter - Video support + userId module support #3937

Merged
merged 47 commits into from
Jul 9, 2019
Merged

PulsePoint adapter - Video support + userId module support #3937

merged 47 commits into from
Jul 9, 2019

Conversation

anand-venkatraman
Copy link
Contributor

@anand-venkatraman anand-venkatraman commented Jun 21, 2019

  • Feature

Description of change

  1. Video InStream and Outstream support
  2. Support for openrtb paramters - bidfloor/badv/bcat/battr
  3. Support for user id modules.

Other information

Test pages below
InStream
OutStream
User Ids

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change
@anand-venkatraman anand-venkatraman changed the title Pulse point video Pulseoint video Jun 21, 2019
@anand-venkatraman anand-venkatraman changed the title Pulseoint video PulsePoint adapter - Video support Jun 21, 2019
@anand-venkatraman anand-venkatraman changed the title PulsePoint adapter - Video support PulsePoint adapter - Video support + userId module support Jun 27, 2019
@robertrmartinez
Copy link
Collaborator

Will take a look now thank you

@anand-venkatraman
Copy link
Contributor Author

@robertrmartinez - did you get a chance to look into this?

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but your test parameters for video do not return bids, So I am not really able to test / validate the response parsing.

Is there something I need to tweak to get it to work?

modules/pulsepointBidAdapter.md Outdated Show resolved Hide resolved
@anand-venkatraman
Copy link
Contributor Author

Not sure why you didnt get a bid, but here are the test pages for outstream and instream. Please give it a go.
http://projects.contextweb.com/av/pb-video/instream/
http://projects.contextweb.com/av/pb-video/outstream/slider.html

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those links. LGTM

@robertrmartinez robertrmartinez merged commit e28792e into prebid:master Jul 9, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* initial commit

* Adding ortb params

* Outstream fixes

* Minor fixes

* Test fixes

* Minor refactor

* Minor changes

* Removing yarn lock file

* battr fix and added test

* PulsePoint adapter - user id module support (#10)

* Making user sync pixels https as well.

* fixing review comment
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* ET-1691: Pulsepoint Analytics adapter for Prebid. (prebid#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* initial commit

* Adding ortb params

* Outstream fixes

* Minor fixes

* Test fixes

* Minor refactor

* Minor changes

* Removing yarn lock file

* battr fix and added test

* PulsePoint adapter - user id module support (prebid#10)

* Making user sync pixels https as well.

* fixing review comment
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* initial commit

* Adding ortb params

* Outstream fixes

* Minor fixes

* Test fixes

* Minor refactor

* Minor changes

* Removing yarn lock file

* battr fix and added test

* PulsePoint adapter - user id module support (prebid#10)

* Making user sync pixels https as well.

* fixing review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants