Fix #3894 - update sizeConfig logic around multiformat bids #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test comment to check github integration in slack |
|
test comment to check github integration in slack 2 |
|
test comment |
jaiminpanchal27
approved these changes
Jul 1, 2019
jaiminpanchal27
added
LGTM
needs 2nd review
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR is a fix for #3894
It modifies the logic used by the sizeConfig when processing a multiformat bid.
If the bid includes a
bannermediaType, then the sizeConfig logic will be respected in that if the label rules don't pass or all the sizes are filtered out, the entire adUnit/bid (whichever is level is checked) will be removed from the request.If the bid does not include the
bannertype (even when the multiformat bid is just native + video), then sizeConfig logic is not applied.Other information
Docs PR: prebid/prebid.github.io#1366