Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oRTB cur to PrebidServer Adapter #3951

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Add oRTB cur to PrebidServer Adapter #3951

merged 3 commits into from
Jul 25, 2019

Conversation

idettman
Copy link
Contributor

Type of change

  • Feature

Description of change

Added: OpenRTB property cur to Prebid Server Adapter.
Setting currency.adServerCurrency will now result in the openRTB JSON containing the obj property cur: ["AAA"]

@idettman idettman requested a review from harpere June 27, 2019 20:40
@idettman idettman added adapter support needs 2nd review Core module updates require two approvals from the core team needs review labels Jun 27, 2019
@stale stale bot added the stale label Jul 15, 2019
@idettman idettman removed the stale label Jul 17, 2019
@bretg bretg assigned idettman and unassigned harpere Jul 23, 2019
@prebid prebid deleted a comment from stale bot Jul 24, 2019
@idettman idettman requested a review from harpere July 24, 2019 11:06
@bretg bretg removed the request for review from robertrmartinez July 25, 2019 19:57
@idettman idettman requested review from snapwich and removed request for bretg and robertrmartinez July 25, 2019 20:36
@idettman idettman removed their assignment Jul 25, 2019
snapwich
snapwich approved these changes Jul 25, 2019
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman added LGTM and removed needs 2nd review Core module updates require two approvals from the core team labels Jul 25, 2019
@idettman idettman merged commit c16640a into prebid:master Jul 25, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
@leonardlabat
Add oRTB cur to PrebidServer Adapter (prebid#3951)
68af7b7 
* Add 'cur' to ORTB obj
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Add oRTB cur to PrebidServer Adapter (prebid#3951)
b05c408 
* Add 'cur' to ORTB obj
@jsnellbaker jsnellbaker mentioned this pull request Oct 8, 2019
Closed
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Add oRTB cur to PrebidServer Adapter (prebid#3951)
04a9fd3 
* Add 'cur' to ORTB obj
@dmitriyshashkin dmitriyshashkin mentioned this pull request Dec 17, 2019
Closed
@idettman idettman deleted the prebidserver-ortb-cur branch February 29, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

@bretg bretg bretg approved these changes

@jaiminpanchal27 jaiminpanchal27 Awaiting requested review from jaiminpanchal27

@harpere harpere Awaiting requested review from harpere

Assignees

@harpere harpere

Labels
adapter support LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idettman @snapwich @bretg @harpere