Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ozone adapter - minor fix to add w/h to video requests #3953

Merged
merged 3 commits into from
Jul 19, 2019
Merged

ozone adapter - minor fix to add w/h to video requests #3953

merged 3 commits into from
Jul 19, 2019

Conversation

afsheenb
Copy link
Contributor

  • [ X] Bugfix

Minor bugfix to include width and height attributes in bid requests for video inventory.

engineering@ozoneproject.com

@afsheenb afsheenb changed the title minor fix to add w/h to video requests ozone adapter - minor fix to add w/h to video requests Jun 29, 2019
@jsnellbaker jsnellbaker requested a review from sumit116 July 1, 2019 12:42
@AskRupert-DM
Copy link
Contributor

AskRupert-DM commented Jul 2, 2019

Hi @sumit116 let us know if you need any info ?

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, While testing on hello_world page, I found that request to https://elb.the-ozone-project.com/openrtb2/auction returns a blank object in response. Ideally it should return the bid object back as response like all other bid adaptors. The request payload I used is

{"device":{"w":1366,"h":657},"site":{"publisher":{"id":"OZONENUK0001"},"page":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"test":1,"id":"6d112b1c-47ee-4f08-88ed-81dddc3db556","auctionId":"6d112b1c-47ee-4f08-88ed-81dddc3db556","imp":[{"id":"236f9339f1b086","tagid":"0440440442","secure":0,"video":{"playerSize":[[640,480]],"mimes":["video/mp4"],"context":"outstream","w":640,"h":480,"format":[{"w":640,"h":480}]},"placementId":"0440440442","publisherId":"OZONENUK0001","siteId":"4204204201","ext":{"prebid":{"storedrequest":{"id":"0440440442"}},"ozone":{"adUnitCode":"id-of-your-video-div","transactionId":"87cdf194-93d0-47ef-8338-faed58343dba","oz_pb_v":"2.1.2","customData":[{"settings":{},"targeting":{"key":"value","key2":["value1","value2"]}}],"lotameData":{"key1":"value1","key2":"value2"}}}}],"source":{"tid":"6d112b1c-47ee-4f08-88ed-81dddc3db556"}}

I am making request from India. Can you please check this at your end?

@AskRupert-DM
Copy link
Contributor

hi @sumit116 - please try again - believe the test response was probably excluded from India so I've set another one up using those same credentials that should target India.

@AskRupert-DM
Copy link
Contributor

hey @sumit116 just checking in if you were able to see the bid-response coming back okay now ?

@sumit116
Copy link
Contributor

hey @sumit116 just checking in if you were able to see the bid-response coming back okay now ?

Hi @AskRupert-DM, I am still unable to get the response.

image

image

@AskRupert-DM
Copy link
Contributor

AskRupert-DM commented Jul 10, 2019

@sumit116 - am I correct in thinking you refreshed / tried a couple of times - you may not get the response back every single time on every request - although i've tried to make a change in the ad-server to force a response each time so hopefully you will see it returned more consistently.

I'm able to get the payload that you are using to serve back a response on my end and can confirm India is included in the geo-targeting for our test ad - please try again and let me know if you still are not seeing it:

image

@sumit116
Copy link
Contributor

@sumit116 - am I correct in thinking you refreshed / tried a couple of times - you may not get the response back every single time on every request - although i've tried to make a change in the ad-server to force a response each time so hopefully you will see it returned more consistently.

I'm able to get the payload that you are using to serve back a response on my end and can confirm India is included in the geo-targeting for our test ad - please try again and let me know if you still are not seeing it:

image

@AskRupert-DM , I refreshed the page multiple times, have rechecked it again now, still I am not getting the response.

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still getting a blank object in the response. Approving the PR based on the request object passed.

@AskRupert-DM
Copy link
Contributor

Thanks @sumit116 think the reason you aren't able to see them is because your making requests coming from a non-whitelisted domain so our endpoint will always return an empty object. Will provide testpage URLs for you to use in future submissions to work around this.

@sumit116
Copy link
Contributor

sumit116 commented Jul 16, 2019

Thanks @sumit116 think the reason you aren't able to see them is because your making requests coming from a non-whitelisted domain so our endpoint will always return an empty object. Will provide testpage URLs for you to use in future submissions to work around this.

Thank you @AskRupert-DM

@jsnellbaker jsnellbaker merged commit 1d92d40 into prebid:master Jul 19, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
* minor fix to add w/h to video requests

* fixing padding/spacing errors caught by circleCI

* fixing padding/spacing errors caught by circleCI, take two
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* minor fix to add w/h to video requests

* fixing padding/spacing errors caught by circleCI

* fixing padding/spacing errors caught by circleCI, take two
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* minor fix to add w/h to video requests

* fixing padding/spacing errors caught by circleCI

* fixing padding/spacing errors caught by circleCI, take two
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants