Teads-adapter: Read placementId from response and add sync informations

[valsouche]

Type of change

• Feature

Description of change

• Read placementId in interpretResponse
• Add some tracking informations during sync call

[valsouche]

Hello,
Do we need to have a green build to be reviewed ? It doesn't look like red because of our changes.
Thank you in advance !

[sumit116]

Hi, While testing on hello_world page, I found that request to http://a.teads.tv/hb/bid-request returns a blank arary in response. Ideally it should return the bid object back as response like all other bid adaptors. I am making request from India. The request payload I used is

{"referrer":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pb_js=true","data":[{"sizes":["300x250"],"bidId":"29593cbbb85992","bidderRequestId":"12e08cf32f4f57","placementId":12345,"pageId":1234,"adUnitCode":"div-gpt-ad-1460505748561-0","auctionId":"70b6515e-7347-483d-ac8f-c6c4b2bcec5b","transactionId":"1a3f8bda-da94-4bd9-9463-25aa5b094e30"},{"sizes":["600x800"],"bidId":"3918f8e5429ae6","bidderRequestId":"12e08cf32f4f57","placementId":12345,"pageId":1234,"adUnitCode":"div-gpt-ad-1460505748561-0","auctionId":"70b6515e-7347-483d-ac8f-c6c4b2bcec5b","transactionId":"37de9a2f-ad0b-4dd9-8961-cb762a6db676"}],"deviceWidth":1366,"hb_version":"2.25.0-pre"}

Secondly, I am getting a console error:

Uncaught TypeError: Cannot read property 'gdprApplies' of undefined
    at Object.getUserSyncs (teadsBidAdapter.js:99)
    at registerSyncs (bidderFactory.js:333)
    at afterAllResponses (bidderFactory.js:190)
    at utils.js:950
    at Object.onSuccess [as success] (bidderFactory.js:299)
    at XMLHttpRequest.x.onreadystatechange (ajax.js:49)

Can you please check these issues at your end?

[valsouche]

Hello @sumit116 , thanks for review.
We fixed the console error in our last commit.

We didn't know that we have to give a test campaign access for this kind of changes (we did that only during the first adaptor pull request and not for others), we will send you ids as soon as there are available.

Thank you in advance.

[valsouche]

Hello @sumit116 , here is a test campaign:
"placementId": 96888, "pageId": 89489

You can try these ids inside the hello word adUnit configuration.

Thank you again.

[sumit116]

Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well, hence approving the PR.