-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrustX Bid Adapter updating to use referrerInfo #3972
Conversation
…size of the request
…ion utils.getTopWindowUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. referrerInfo
is getting added to request payload as param u
, hence approving the PR.
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request * Update TrustX Bid Adapter to support instream and outstream video * Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter * Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl
Prebid Team,
This is an urgent request.
We have made a bug fix, that we ask you include in the current release. Details found here:
#4039
Please confirm when this has been reviewed and merged.
Best,
Paul
PAUL WYREMBAK
TRUSTX<http://www.trustx.org/> | Head of Technical Operations
530 Seventh Ave, New York, NY 10018
+1 631.428.9992<tel:+1%20631.428.9992>
[X Logo]<http://www.trustx.org/>
…-------- Original message --------
From: jsnellbaker <notifications@github.com>
Date: 7/24/19 15:29 (GMT-05:00)
To: "prebid/Prebid.js" <Prebid.js@noreply.github.com>
Cc: Paul Wyrembak <Paul@trustx.org>, Author <author@noreply.github.com>
Subject: Re: [prebid/Prebid.js] TrustX Bid Adapter updating to use referrerInfo (#3972)
Merged #3972<#3972> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3972?email_source=notifications&email_token=AGDOTOEFXSDXUZABFEVL7HTQBCUQ5A5CNFSM4H65N6F2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSVZ7DNQ#event-2507403702>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGDOTOACFREXBQYYFAOCHJ3QBCUQ5ANCNFSM4H65N6FQ>.
|
Hi @PWyrembak To confirm, PR #4039 has been reviewed/merged. It should be part of the 2.26.0 release, which we expect to go out later today. Please let us know if you have any other questions/concerns. Thanks, |
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request * Update TrustX Bid Adapter to support instream and outstream video * Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter * Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request * Update TrustX Bid Adapter to support instream and outstream video * Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter * Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl
Type of change
Description of change
Use refererInfo instead deprecated function utils.getTopWindowUrl.