Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn Analytics : Calculate highest bid based on ad unit #3973

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

jrosendahl
Copy link
Contributor

@jrosendahl jrosendahl commented Jul 8, 2019

Type of change

  • [X ] Bugfix

Description of change

Update Sovrn Analytics Adapter highest bid calculation to be based on ad unit rather than auction

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mike-chowla mike-chowla self-assigned this Jul 9, 2019
@mike-chowla mike-chowla changed the title Fix to analytics Adaptor Sovrn Analytics : Fix Adapter Jul 9, 2019
@mike-chowla mike-chowla changed the title Sovrn Analytics : Fix Adapter Sovrn Analytics : Fix so highest bid calculation to be based on ad unit rather than auction Jul 9, 2019
@mike-chowla mike-chowla changed the title Sovrn Analytics : Fix so highest bid calculation to be based on ad unit rather than auction Sovrn Analytics : Calculate highest bid tobased on ad unit Jul 9, 2019
@mike-chowla mike-chowla changed the title Sovrn Analytics : Calculate highest bid tobased on ad unit Sovrn Analytics : Calculate highest bid based on ad unit Jul 9, 2019
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit ca16968 into prebid:master Jul 9, 2019
@jrosendahl jrosendahl deleted the SNEK-XXAdapterFix branch July 10, 2019 17:15
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants