Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My6Sense: Endpoint subdomain changed. #3982

Merged
merged 10 commits into from
Jul 22, 2019
Merged

My6Sense: Endpoint subdomain changed. #3982

merged 10 commits into from
Jul 22, 2019

Conversation

my6sense
Copy link
Contributor

Type of change

  • [x ] Other

Description of change

we changed the endpoint url (old url still works).

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg bretg changed the title Endpoint subdomain changed. My6Sense: Endpoint subdomain changed. Jul 22, 2019
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, noticed that this is a different implementation. Please provide a test page with test params so we can verify that bids are returned.

@bretg
Copy link
Collaborator

bretg commented Jul 22, 2019

We're trying to enforce the rules about making sure that changes like this are tested with an appropriate page. Tried the params at https://github.com/prebid/Prebid.js/blob/master/modules/my6senseBidAdapter.md file and got a bid from either hostname. Looks fine.

@bretg bretg merged commit fa9d4be into prebid:master Jul 22, 2019
@my6sense
Copy link
Contributor Author

thank you!

leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
* My6sense new adapter

* endpoint fix

* Code fix

* Added changes in adapter md file

* Changed the end point

* supportedMediaTypes values added

* md file was updated with a valid widget key

* endpoint changed

* indentation issues fixed
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* My6sense new adapter

* endpoint fix

* Code fix

* Added changes in adapter md file

* Changed the end point

* supportedMediaTypes values added

* md file was updated with a valid widget key

* endpoint changed

* indentation issues fixed
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* My6sense new adapter

* endpoint fix

* Code fix

* Added changes in adapter md file

* Changed the end point

* supportedMediaTypes values added

* md file was updated with a valid widget key

* endpoint changed

* indentation issues fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants