Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubicon analytics adapter with wrapper name #3990

Merged
merged 22 commits into from
Jul 23, 2019
Merged

Update rubicon analytics adapter with wrapper name #3990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8d635ff
Add microadBidAdapter
Feb 15, 2019
3055b90
Remove unnecessary encodeURIComponent from microadBidAdapter
Feb 26, 2019
67fb91b
Submit Advangelists Prebid Adapter
Feb 26, 2019
3ebb916
Submit Advangelists Prebid Adapter 1.1
Feb 27, 2019
4f5c451
Correct procudtion endpoint for prebid
Feb 28, 2019
2dc6d1d
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
Feb 28, 2019
fa3e081
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
Mar 18, 2019
600a46e
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
Mar 18, 2019
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
Mar 23, 2019
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
Mar 26, 2019
9abf89c
Merge branch 'master' of https://github.com/prebid/Prebid.js
May 13, 2019
6ce04ab
Merge remote-tracking branch 'upstream/master'
Jun 10, 2019
415e2f6
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
Jun 27, 2019
61fb82c
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
Jul 11, 2019
3cc4c67
analytics update with wrapper name
Jul 11, 2019
1e880b9
changed to only send wrapperName with event when it has a value
Jul 12, 2019
f074963
changed wrapperName to use value from config 'rubicon.wrapperName'
Jul 12, 2019
cd81e02
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
Jul 15, 2019
8279090
Merge branches 'master' and 'rubicon-analytics-adapter-add-wrappernam…
Jul 15, 2019
8460793
update tests for wrapperName
Jul 15, 2019
6ae5fcb
update wrapperName as let for consistency
Jul 15, 2019
bf69fa1
updated wrapperName from let to const
Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/rubiconAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ function sendMessage(auctionId, bidWonId) {
version: '$prebid.version$',
referrerUri: referrer
};
const wrapperName = config.getConfig('rubicon.wrapperName');
if (wrapperName) {
message.wrapperName = wrapperName;
}
let auctionCache = cache.auctions[auctionId];
if (auctionCache && !auctionCache.sent) {
let adUnitMap = Object.keys(auctionCache.bids).reduce((adUnits, bidId) => {
Expand Down
6 changes: 5 additions & 1 deletion test/spec/modules/rubiconAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,8 @@ const ANALYTICS_MESSAGE = {
},
'bidwonStatus': 'success'
}
]
],
'wrapperName': '10000_fakewrapper_test'
};

function performStandardAuction() {
Expand Down Expand Up @@ -487,6 +488,9 @@ describe('rubicon analytics adapter', function () {
s2sConfig: {
timeout: 1000,
accountId: 10000,
},
rubicon: {
wrapperName: '10000_fakewrapper_test'
}
})
});
Expand Down
3 changes: 3 additions & 0 deletions test/spec/modules/rubiconAnalyticsSchema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@
}
]
}
},
"wrapperName": {
"type": "string"
}
},
"definitions": {
Expand Down