Deep libs and lint fix #3993
Merged
Deep libs and lint fix #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Jul 23, 2019
jaiminpanchal27
added
needs 2nd review
|
Hi @snapwich Can you please take a look at the conflicts when you have the chance? |
snapwich
force-pushed
the
deep-libs-and-lint-fix
branch
from
2f84dd6
to
96516be
Compare
|
updated |
|
@snapwich Can you resync with We separately removed the The changes look good otherwise. |
jsnellbaker
approved these changes
Jul 25, 2019
snapwich
force-pushed
the
deep-libs-and-lint-fix
branch
from
96516be
to
fbc64fe
Compare
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* make sure linter checks re-export imports. * replace deepAccess and deepSetValue with better npm libs * move re-exports to top of utils
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* make sure linter checks re-export imports. * replace deepAccess and deepSetValue with better npm libs * move re-exports to top of utils
1 task
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* make sure linter checks re-export imports. * replace deepAccess and deepSetValue with better npm libs * move re-exports to top of utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Replaced the
utils.deepAccessandutils.deepSetValuewith npm libs that are smaller, better tested, and support more functionality such as array paths and default values.Fixed linter so that it also checks re-exported imports