Adkernel adapter minor update #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like build failure is caused by localStorage usage in widespace bid adapter. |
|
CircleCI is just flaky sometimes. Kicked it off again it succeeded this time. @sumit116 to review the code. |
sumit116
approved these changes
Jul 23, 2019
jsnellbaker
requested changes
Jul 23, 2019
There was a problem hiding this comment.
The overall changes look good. Can you though put together some unit tests for the new utils function that was added?
The adapter's unit tests are fine, but it'd be ideal to have something for the new function as well. We should be good to merge at that point. Thanks.
ckbo3hrk
force-pushed
the
adkernel_actualize
branch
from
ac95625
to
71f16ed
Compare
|
@jsnellbaker Requested unit test has been added. |
jsnellbaker
approved these changes
Jul 24, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* Updated maintainer email * Minor refactoring & more unit tests * Unit tests for new utility function
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Updated maintainer email * Minor refactoring & more unit tests * Unit tests for new utility function
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Updated maintainer email * Minor refactoring & more unit tests * Unit tests for new utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change