Padsquad bid adapter #4002
Merged
Padsquad bid adapter #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like build failure is caused by other bid adapters |
Fawke
reviewed
Jul 17, 2019
modules/padsquadBidAdapter.js
Outdated
| } | ||
| } | ||
| }); | ||
| utils.logInfo('padsquad.getUserSyncs result=%o', syncs); |
There was a problem hiding this comment.
The log message is a bit ambiguous. Would you mind fixing that or making it more coherent as to what it means?
There was a problem hiding this comment.
actually that line may not even be necessary, we'll remove it altogether
Fawke
requested changes
Jul 17, 2019
There was a problem hiding this comment.
@yeeldpadsquad Everything seems great, the adapter's been tested with the test parameters that you sent, it works fine.
On small point, you might wanna take a look at the inline comment.
Fawke
approved these changes
Jul 22, 2019
Fawke
added
the
needs 2nd review
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* padsquad bid adapter * padsquad bid adapter * removed unnecessary log line
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* padsquad bid adapter * padsquad bid adapter * removed unnecessary log line
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* padsquad bid adapter * padsquad bid adapter * removed unnecessary log line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New Padsquad bid adapter
Documentation
prebid/prebid.github.io#1390