GumGum adapter: push first indexed value in sizes array to bidResponses.height and width #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Jul 22, 2019
|
@bretg please let me know if there is anything else to be adjusted here. |
bretg
approved these changes
Aug 7, 2019
bretg
changed the title
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
…es.height and width (prebid#4006) * changed resizing unit tests to return the first size dimensions in the sizes array * added some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This pull request will change GumGum's bid adapter to return the width and height of the first indexed value in the sizes array. This change will allow our adapter to dynamically populate the ad size of our bid response to match the request size that the publisher sends us.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
CC: @susyt