adformOpenRTB adapter: support currency param #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Jul 23, 2019
There was a problem hiding this comment.
While it's ok for you to accept the currency as a bidder-specific param, please also support the standard PBJS location for defining currency. http://prebid.org/dev-docs/modules/currency.html
pbjs.getConfig("currency.adserverCurrency");
|
Somehow missed this functionality. There is no need to have separate parameter then. |
2 tasks
bretg
approved these changes
Jul 25, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* adformOpenRTB adapter: support currency param * use common currency settings
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* adformOpenRTB adapter: support currency param * use common currency settings
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* adformOpenRTB adapter: support currency param * use common currency settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added new adformOpenRTB bid config option.
contact email of the adapter’s maintainer
Scope.FL.Scripts@adform.com
official adapter submission