Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adformOpenRTB adapter: size targeting using aspect ratios #4019

Merged
merged 2 commits into from
Jul 30, 2019
Merged

adformOpenRTB adapter: size targeting using aspect ratios #4019

merged 2 commits into from
Jul 30, 2019

Conversation

braizhas
Copy link
Contributor

Type of change

  • Feature

Description of change

Pass aspect_ratios config to adserver.

@bretg bretg changed the title adformOpenRTB adatper: size targeting using aspect ratios adformOpenRTB adapter: size targeting using aspect ratios Jul 26, 2019
@bretg bretg requested a review from msm0504 July 26, 2019 03:11
msm0504
msm0504 reviewed Jul 26, 2019
View reviewed changes
modules/adformOpenRTBBidAdapter.js Show resolved Hide resolved
modules/adformOpenRTBBidAdapter.js Outdated Show resolved Hide resolved
msm0504
msm0504 approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after latest commit

@msm0504 msm0504 merged commit 0561222 into prebid:master Jul 30, 2019
@braizhas braizhas deleted the adformAdapter-aspect-ratios branch July 31, 2019 08:14
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@braizhas
adformOpenRTB adapter: size targeting using aspect ratios (prebid#4019)
b5877e6 
* adformOpenRTB adatper: size targeting using aspect ratios

* avoid throwing errors while parsing aspect_ratios
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 6, 2019
@braizhas @leonardlabat
adformOpenRTB adapter: size targeting using aspect ratios (prebid#4019)
3d40d86 
* adformOpenRTB adatper: size targeting using aspect ratios

* avoid throwing errors while parsing aspect_ratios
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
@braizhas
adformOpenRTB adapter: size targeting using aspect ratios (prebid#4019)
a04c3b3 
* adformOpenRTB adatper: size targeting using aspect ratios

* avoid throwing errors while parsing aspect_ratios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msm0504 msm0504 msm0504 approved these changes

Assignees

@msm0504 msm0504

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braizhas @msm0504