Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mgid] add referrer and utc offset to bid request #4023

Merged
merged 5 commits into from
Jul 31, 2019
Merged

[mgid] add referrer and utc offset to bid request #4023

merged 5 commits into from
Jul 31, 2019

Conversation

Gaudeamus
Copy link
Contributor

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)

add referrer and utc offset to bid request

  • contact email of the adapter’s maintainer
    prebid@mgid.com
  • official adapter submission

@bretg
Copy link
Collaborator

bretg commented Jul 26, 2019

@mike-chowla - please consider overlap of the pageinfo function here with what we have in utils.js. Thanks.

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla
Copy link
Contributor

@mike-chowla - please consider overlap of the pageinfo function here with what we have in utils.js. Thanks.

I don't see a function in utils that gives a reference to the top most window back. If the caller just needs the referrer, we have a function for that but given the code is using innerWidth & innerHeight, I don't see a way to do this with the existing utils functions or passed in refererInfo

@mike-chowla mike-chowla merged commit 30cfb6d into prebid:master Jul 31, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* make placementId optional

* get referrer

* fix formatting

* fix formatting
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* make placementId optional

* get referrer

* fix formatting

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants