TripleLift adapter: Always use secure endpoint #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update contact for TL updates/Prebid Q&A
Fix STR_ENDPOINT to always go to tlx secure endpoint
bretg
changed the title
bretg
reviewed
Jul 28, 2019
| @@ -3,7 +3,7 @@ | |||
| ``` | |||
| Module Name: Triplelift Bid Adapter | |||
| Module Type: Bidder Adapter | |||
| Maintainer: bzellman@triplelift.com | |||
| Maintainer: csmith+s2s@triplelift.com | |||
There was a problem hiding this comment.
For the record, we would prefer that maintainer addresses be groups rather than individuals.
bretg
approved these changes
Jul 28, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* Update contact Update contact for TL updates/Prebid Q&A * Always Secure Fix STR_ENDPOINT to always go to tlx secure endpoint * Update test to always_secure * Update tripleliftBidAdapter.md
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Update contact Update contact for TL updates/Prebid Q&A * Always Secure Fix STR_ENDPOINT to always go to tlx secure endpoint * Update test to always_secure * Update tripleliftBidAdapter.md
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Update contact Update contact for TL updates/Prebid Q&A * Always Secure Fix STR_ENDPOINT to always go to tlx secure endpoint * Update test to always_secure * Update tripleliftBidAdapter.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update to always secure
const STR_ENDPOINT = document.location.protocol + '//tlx.3lift.com/header/auction?';to
const STR_ENDPOINT = 'https://tlx.3lift.com/header/auction?';