Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instream & outstream video support to Criteo adapter #4037

Merged
merged 8 commits into from
Aug 6, 2019

Conversation

leonardlabat
Copy link
Contributor

@leonardlabat leonardlabat commented Jul 30, 2019

Type of change

  • Feature

Description of change

We'd like to add the support for instream & outstream videos in our adapter.

Here's a sample of addUnit for an instream video query.

var videoAdUnit = {
    code: 'div-Test-DirectBidder-Video',
    mediaTypes: {
      video: {
        context: "instream",
        mimes: ["video/mp4","application/javascript"],
        maxduration: 30,
        api: [1, 2],
        playerSize: [640,480],
        protocols: [2, 3, 5, 6]
      }
    },
    bids: [
      {
        bidder: 'criteo',
        params: {
          zoneId: 1424176,
          video: {
            skip: 0,
            playbackmethod: 1,
            placement: 1
          }
        }
      }
    ]
  };

PR for documentation is available here : prebid/prebid.github.io#1414

@leonardlabat
Copy link
Contributor Author

Hello !

Any chance that you have a look to that PR ?

Thanks a lot

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks.

+1 on using the forEach on validating all the video params you require :)

@robertrmartinez robertrmartinez merged commit a0ba466 into prebid:master Aug 6, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* assign adapter version

* Mapped video parameter from prebid.js to cdb

* Mapped video parameter from prebid.js to cdb

* Ensure that context is consistent with placement and that we do not support longform

* updated playersize property name

* fixed size parsing to be able to handle single player size as well as several

* Changed playersize to plural playersizes in CDB contract

* Use displayurl instead of creative as we want to fetch the direct url vast cache instead a vast wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants