Update karma to address vulnerabilities. #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update - command |
@jsnellbaker I've fixed this. The command |
jsnellbaker
added
LGTM
needs 2nd review
jsnellbaker
approved these changes
Jul 31, 2019
jaiminpanchal27
approved these changes
Jul 31, 2019
1 task
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* update packages to fix vulns * upgrade node version to support advanced features * fix command gulp test --browserstack not exiting * fixes gulp view-coverage command failing * fix: command, gulp serve now keeps running without exiting * fix: error in package-lock.json * update README.md to reflect change in node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Related to #3966. The earlier PR was reverted because Circle CI failed. This PR attempts to fix the failing CI along with the necessary updates required to keep vulnerabilities to a minimum.
The updated package
karma v^4.2.0uses object spread operator which is supported only in Node v9 or greater, hence this PR updates minimum supported Node version to 9.