Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onetagBidAdapeter.js: minor fix and updates according to documentation #4054

Merged
merged 2 commits into from
Aug 2, 2019
Merged

onetagBidAdapeter.js: minor fix and updates according to documentation #4054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db0ea31
Minor bug fixing in onetagBidAdapter.js
onetag-dev Jul 31, 2019
e524e94
Merge pull request #1 from OneTagDevOps/OneTagDevOps-patch-2
onetag-dev Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/onetagBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function isBidRequestValid(bid) {
return false;
}

if (typeof bid.params.pubId !== 'string' || bid.sizes === 'undefined' || bid.sizes.length === 0) {
if (typeof bid.params.pubId !== 'string' || typeof bid.sizes === 'undefined' || bid.sizes.length === 0) {
return false;
}

Expand Down Expand Up @@ -82,7 +82,7 @@ function interpretResponse(serverResponse, request) {
netRevenue: false,
mediaType: bids.type ? bids.type : BANNER,
ad: bid.ad,
ttl: bid.ttl || 6000
ttl: bid.ttl || 300
});
});
}
Expand Down