Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new BidAdapter 'eywamedia' #4055

Merged
merged 5 commits into from
Aug 6, 2019

Conversation

sharathdn1
Copy link
Contributor

@sharathdn1 sharathdn1 commented Aug 2, 2019

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'eywamedia',
  params: {
    publisherId: "1234_abcd"
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@Fawke Fawke requested review from Fawke and jsnellbaker August 5, 2019 14:01
@Fawke
Copy link
Contributor

Fawke commented Aug 5, 2019

Hey @Sharatheywa

I was in the process of testing the bid response, but, for some reason, the call to your Ad server is failing, it's behaving very erratically. I've attached a screenshot.

Screenshot 2019-08-05 at 8 01 37 PM

The first request to your ad server, with HTTP method OPTIONS is returning 200, but the actual post call is just stalling out.

Sometimes when I refresh, it starts working again. I am testing with the test parameter you gave in the PR description.

@sharathdn1
Copy link
Contributor Author

sharathdn1 commented Aug 6, 2019

Hi @Fawke,
May be it was due to little delay in the response time, I've optimised it. Can you please check again.

@Fawke
Copy link
Contributor

Fawke commented Aug 6, 2019

@Sharatheywa Thanks for making the change, the ad seems to be loading consistently now. One more thing, I checked your response headers coming back from the call to your ad server and notice that the content-encoding is not set to gzip. Can you GZIP your response?

@sharathdn1
Copy link
Contributor Author

@Sharatheywa Thanks for making the change, the ad seems to be loading consistently now. One more thing, I checked your response headers coming back from the call to your ad server and notice that the content-encoding is not set to gzip. Can you GZIP your response?

Done.

@sharathdn1
Copy link
Contributor Author

Please check now

@Fawke Fawke merged commit 2215c54 into prebid:master Aug 6, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 6, 2019
* Adding new BidAdapter 'eywamedia'

* removed unused import

* removed unused variables

* removed unused import

* removed unused import - my bad!
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* Adding new BidAdapter 'eywamedia'

* removed unused import

* removed unused variables

* removed unused import

* removed unused import - my bad!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants