Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of Instream/Outstream Video for the SmileWanted Adapter #4064

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Adding support of Instream/Outstream Video for the SmileWanted Adapter #4064

merged 1 commit into from
Aug 9, 2019

Conversation

MaxSmileWanted
Copy link
Contributor

This PR allows video support (Instream and Outstream) for the SmileWanted adapter.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Testing

Video Instream

    var videoAdUnit = {
        code: 'video1',
        mediaTypes: {
            video: {
                playerSize: [640, 480],
                context: 'instream'
            }
        },
        bids: [{
            bidder: 'smilewanted',
            params: {
                zoneId: 2,
            }
        }]
    };

Video Outstream

    var videoAdUnit = {
        code: 'video1',
        mediaTypes: {
            video: {
                playerSize: [640, 480],
                context: 'outstream'
            }
        },
        bids: [{
            bidder: 'smilewanted',
            params: {
                zoneId: 3,
            }
        }]
    };

@Fawke
Copy link
Contributor

Fawke commented Aug 8, 2019

@MaxSmileWanted Hey, sorry for the delay in response. This PR looks fine, there's one thing you can do though. You can update your docs PR here, update the metadata section of your markdown file to include this key media_types and set it to whatever Ad format your adapter supports.

As an example,

layout: bidder
title: SmileWanted
description: SmileWanted Bidder Adaptor
media_types: banner, video
hide: true
biddercode: smilewanted
gdpr_supported: true

@MaxSmileWanted
Copy link
Contributor Author

Hi @Fawke,

Oh no worries the time frame is not very long, two days is not much, compared to other projects ;)

I create the PR on the doc site : prebid/prebid.github.io#1426

Thanks

@Fawke Fawke merged commit 6d9f85e into prebid:master Aug 9, 2019
Fawke pushed a commit to prebid/prebid.github.io that referenced this pull request Aug 9, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants