Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SupplyChain object support in Prebid #4084
SupplyChain object support in Prebid #4084
Changes from all commits
b66e75a
edd7614
3c9227f
f0fcc28
e5dd135
16bd479
7d4cfde
e4cef55
4f7ba93
f7f9f3f
f44628e
ec0c32f
9e6ee7d
51d12e6
abdcbe6
2fe6047
80b1787
693399c
7320a52
88f495f
d09eab4
e9606bf
355e353
1458815
f73d4c1
b7fa658
25f877c
b30dcaf
e891b9d
9072e73
02e2e38
9b2a639
fec36b8
4c218f3
31d00d5
e344855
7e4188f
fd34738
01b9c68
0c896df
1f9d0eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern: the schema ultimately depends upon the version of the Supply Chain spec that is being used. Ex: they recently released a "final" version of the previous draft that renamed a number of fields.
To accommodate this, a lot of the validation logic will probably need to be dependent upon the version. Ex:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this a bit more, though... I'm concerned about the fact that "Prebid.js" and "The Supply Chain Spec" have completely different release cycles. That is: there could be a new release of the "Supply Chain Spec" at any time. With the current arrangement, it seems like nobody would be able to upgrade to this new version of the "Supply Chain Spec" until after there has been a Prebid.js update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had asked @pm-harshad-mane to put the validation logic in. Considering we're facing a deadline from some DSPs to complete the schain work, I'm wondering if the better option is just to remove the validation logic and let bidders validate the schain objects themselves if they wish to.