update adUnit, bidRequest and bidResponse object #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let appnexusBidRequests = find(bidRequests, bidRequest => bidRequest.bidderCode === 'appnexus'); | ||
| expect(appnexusBidRequests.bids.length).to.equal(2); | ||
| expect(appnexusBidRequests.bids[0].sizes).to.deep.equal(find(adUnits, adUnit => adUnit.code === appnexusBidRequests.bids[0].adUnitCode).sizes); | ||
| expect(appnexusBidRequests.bids[1].sizes).to.deep.equal(find(adUnits, adUnit => adUnit.code === appnexusBidRequests.bids[1].adUnitCode).sizes); |
There was a problem hiding this comment.
@Fawke
Should these expects be updated to check the mediaTypes.sizes or whatever the expected is?
instead of just removing them?
There was a problem hiding this comment.
Thanks @robertrmartinez for pointing this out! I've added a few assertions to check for the mediaType object. Let me know what you think.
jaiminpanchal27
approved these changes
Sep 24, 2019
jaiminpanchal27
added
LGTM
needs 2nd review
jsnellbaker
approved these changes
Sep 24, 2019
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR updates the AdUnit, BidRequest & BidResponse objects in the
fixtures.jsfile to addmediaTypeproperty and remove the deprecatedsizesproperty. Also, some irrelevant properties from few of these objects have also been removed.If I did miss updating some objects, please let me know so I can look into it and make the required change.