Added Turk Telekom Bid Adapter #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit116
suggested changes
Sep 26, 2019
There was a problem hiding this comment.
Hi @turktelssp, Thanks for submitting your adapter. I tested it on hello_world page and found things working well. Just observed a couple of changes required in .md file, rest looks good.
modules/turktelekomBidAdapter.md
Outdated
| var adUnits = [ | ||
| { | ||
| code: 'test-div', | ||
| sizes: [[300, 250]], |
There was a problem hiding this comment.
the sizes param should be moved to mediaTypes: { sizes: [] }, I saw Prebid.js throwing warning if sizes is passed outside mediaTypes.
modules/turktelekomBidAdapter.md
Outdated
| ] | ||
| },{ | ||
| code: 'test-div', | ||
| sizes: [[640, 360]], |
There was a problem hiding this comment.
same as above. For video sizes can also be used as playerSize.
|
@sumit116 - I don't see this PR on the releases page -- please add it. |
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New Bid Adapter for Türk Telekom
turktelssp@gmail.com
official adapter submission
A link to a PR on the docs repo Added doc file for Turk Telekom Bid Adapter prebid.github.io#1495