-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parrable ID submodule #4266
Add Parrable ID submodule #4266
Conversation
You also need to modify the PrebidServerBidAdapter https://github.com/prebid/Prebid.js/blob/master/modules/prebidServerBidAdapter/index.js to add something like this in the section around line 700:
|
Thanks @bretg . I pushed the required changes. The CircleCI build seems to be failing on something not related to our PR. I cannot restart the build. Can you please check this. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eyas-ranjous Please see comments. Also you need to add your module in .submodules.json
file
@jaiminpanchal27 @bretg all requested changes addressed in this PR. We are going to create the refresh feature into a different PR. Please consider merging this PR if everything looks good to you. Thanks. |
Type of change
Description of change
* The Parrable ID that is delivered to Prebid is encrypted by Parrable with a time-based key and updated frequently in the browser to enforce consumer privacy requirements and thus we added a feature to always refresh the stored ID when a submodule belongs to a "submodulesThatAlwaysRefresh" list. Ours is the first.