Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parrable ID submodule #4266

Merged
merged 22 commits into from
Oct 15, 2019

Conversation

eyas-ranjous
Copy link
Contributor

@eyas-ranjous eyas-ranjous commented Oct 7, 2019

Type of change

  • Feature

Description of change

  • Add Parrable ID submodule to userId to create and store the device encrypted ID in order to be included in the bid request.

* The Parrable ID that is delivered to Prebid is encrypted by Parrable with a time-based key and updated frequently in the browser to enforce consumer privacy requirements and thus we added a feature to always refresh the stored ID when a submodule belongs to a "submodulesThatAlwaysRefresh" list. Ours is the first.

@bretg
Copy link
Collaborator

bretg commented Oct 10, 2019

You also need to modify the PrebidServerBidAdapter https://github.com/prebid/Prebid.js/blob/master/modules/prebidServerBidAdapter/index.js to add something like this in the section around line 700:

      if (bidUserId.parrableId) {
        request.user.ext.eids.push({
          source: 'parrable.com',
          uids: [{
            id: bidUserId.parrableId
          }]
        });
      }

@eyas-ranjous
Copy link
Contributor Author

Thanks @bretg . I pushed the required changes. The CircleCI build seems to be failing on something not related to our PR. I cannot restart the build. Can you please check this. Thanks.

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyas-ranjous Please see comments. Also you need to add your module in .submodules.json file

modules/userId/index.js Outdated Show resolved Hide resolved
test/spec/modules/userId_spec.js Outdated Show resolved Hide resolved
@eyas-ranjous
Copy link
Contributor Author

@jaiminpanchal27 @bretg all requested changes addressed in this PR. We are going to create the refresh feature into a different PR. Please consider merging this PR if everything looks good to you. Thanks.

@icflournoy icflournoy deleted the add-parrable-id-system branch August 4, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants