SpotX Bid Adapter: Support schain, ID5 object, Google consent object, and hide_skin #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ID5 object support - Added Google Consent object - Reformatted indentaiton on spec file
- not sure how these got moved, lets put them back
- no reason to use this one in the example
- schain object is now added to ortb request body at request.ext.source.ext.schain
Spotx adapter - Add schain support and update unit tests
- whoops, this got removed, let's add it back
codybonney
changed the title
bretg
approved these changes
Oct 11, 2019
|
Mark is out this week. I went ahead and reviewed. Merging. |
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change