Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smartrtbBidAdapter #4362

Merged
merged 11 commits into from
Oct 23, 2019
Merged

Update smartrtbBidAdapter #4362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c1d9002
modules: Implement SmartRTB adapter and spec.
evanmsmrtb Feb 21, 2019
c399c12
Fix for-loop syntax to support IE; refactor getDomain out of exported…
evanmsmrtb Feb 25, 2019
5ca32ff
Update smartrtb adapter - add video, id* support
evanmsmrtb Oct 1, 2019
e01bf25
Merge branch 'master' of https://github.com/prebid/Prebid.js into smr…
evanmsmrtb Oct 1, 2019
5a7485d
Remove debugs, update doc
evanmsmrtb Oct 1, 2019
fc827eb
Update test for video support
evanmsmrtb Oct 7, 2019
611131c
Handle missing syncs. Add video to media types in sample ad unit
evanmsmrtb Oct 8, 2019
b4634d0
Add null response check, update primary endpoint
evanmsmrtb Oct 9, 2019
862e954
Note smrtb video requires renderer
evanmsmrtb Oct 11, 2019
6670509
Remove old params checks, fix documentation playerSize field name
evanmsmrtb Oct 22, 2019
4ce631a
Fix master merge conflicts
evanmsmrtb Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions modules/smartrtbBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,8 @@ function getDomain () {
export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [ 'banner', 'video' ],
aliases: ['smrtb'],
isBidRequestValid: function(bid) {
return (bid.params.pubId !== null &&
bid.params.medId !== null &&
bid.params.zoneId !== null);
return (bid.params.zoneId !== null);
},
buildRequests: function(validBidRequests, bidderRequest) {
let stack = (bidderRequest.refererInfo &&
Expand Down
2 changes: 1 addition & 1 deletion modules/smartrtbBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Video is supported but requires a publisher supplied adunit renderer at this tim
},
video: { /* requires publisher supplied renderer */
context: 'outstream',
playerDimension: [640, 480]
playerSize: [640, 480]
}
},
bids: [
Expand Down