Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added additional ad unit counters #4448

Merged
merged 1 commit into from
Dec 10, 2019
Merged

added additional ad unit counters #4448

merged 1 commit into from
Dec 10, 2019

Conversation

alexkh13
Copy link
Contributor

Type of change

  • Feature

Description of change

Added bidder specific counters on the bidderRequest object:

bidderRequestsCount
bidderWinsCount

Relatively, counts number requests and wins for the specific bidder in context.

#4384

@mike-chowla mike-chowla requested a review from Fawke November 11, 2019 22:51
@jaiminpanchal27 jaiminpanchal27 self-requested a review November 13, 2019 15:20
jaiminpanchal27
jaiminpanchal27 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaiminpanchal27 jaiminpanchal27 assigned mkendall07 and unassigned Fawke Nov 25, 2019
@jaiminpanchal27 jaiminpanchal27 added LGTM needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Nov 25, 2019
@Fawke Fawke removed their request for review December 3, 2019 07:46
mkendall07
mkendall07 approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsnellbaker jsnellbaker merged commit df35628 into prebid:master Dec 10, 2019
@alexkh13 alexkh13 deleted the feature/request-counts branch February 20, 2020 16:02
@patmmccann patmmccann mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexkh13 @mkendall07 @jaiminpanchal27 @mike-chowla @Fawke @jsnellbaker