Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewability to e-planning bid adapter #4471

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Add viewability to e-planning bid adapter #4471

merged 7 commits into from
Dec 10, 2019

Conversation

fndigrazia
Copy link
Contributor

Type of change

  • Feature

Description of change

This PR adds viewability tracking to our e-planning bid adapter, and changes one of our request parameters. It also fixes #4132

Other information

We added an observer to be able to track adunits whose divs weren't yet rendered when buildRequests is first called. Unfortunately we ran into some problems while testing this feature, due to its asynchronous nature, the test code was finishing before the observer callback was called. Any ideas on how we can test this? Thanks.

@bretg
Copy link
Collaborator

bretg commented Nov 25, 2019

Unit tests are broken with this change. I re-ran them many times. Failure is

IE 11.0.0 (Windows 10.0.0) ERROR
  {
    "message": "Object doesn't support property or method 'forEach'\nat webpack:///modules/eplanningBidAdapter.js:218:6 <- test/test_index.js:139444:7\n\nTypeError: Object doesn't support property or method 'forEach'\n   at Anonymous function (webpack:///modules/eplanningBidAdapter.js:218:6 <- test/test_index.js:139444:7)\n   at Anonymous function (webpack:///modules/eplanningBidAdapter.js:217:4 <- test/test_index.js:139443:5)",
    "str": "Object doesn't support property or method 'forEach'\nat webpack:///modules/eplanningBidAdapter.js:218:6 <- test/test_index.js:139444:7\n\nTypeError: Object doesn't support property or method 'forEach'\n   at Anonymous function (webpack:///modules/eplanningBidAdapter.js:218:6 <- test/test_index.js:139444:7)\n   at Anonymous function (webpack:///modules/eplanningBidAdapter.js:217:4 <- test/test_index.js:139443:5)"
  }

@fndigrazia
Copy link
Contributor Author

Fixed the observed error but unrelated tests failed

@Nistenf
Copy link
Contributor

Nistenf commented Dec 2, 2019

Checks are now green

@sebaperez
Copy link
Contributor

Hi @bretg @mike-chowla any update regarding this? Could it be merged? Thanks!

@mike-chowla mike-chowla self-requested a review December 10, 2019 18:35
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit a7c5b80 into prebid:master Dec 10, 2019
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* add viewability e-planning bid adapter

* change viewability and spaces name

* fix in viewability

* fix in viewability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eplanning bid adapter will never return test bid.
5 participants