-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add viewability to e-planning bid adapter #4471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests are broken with this change. I re-ran them many times. Failure is
|
Fixed the observed error but unrelated tests failed |
Checks are now green |
Hi @bretg @mike-chowla any update regarding this? Could it be merged? Thanks! |
mike-chowla
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
* add viewability e-planning bid adapter * change viewability and spaces name * fix in viewability * fix in viewability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds viewability tracking to our e-planning bid adapter, and changes one of our request parameters. It also fixes #4132
Other information
We added an observer to be able to track adunits whose divs weren't yet rendered when buildRequests is first called. Unfortunately we ran into some problems while testing this feature, due to its asynchronous nature, the test code was finishing before the observer callback was called. Any ideas on how we can test this? Thanks.