Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucfunnel adapter change cookie sync setting #4535

Merged
merged 37 commits into from
Dec 11, 2019

Conversation

ucfunnel
Copy link
Contributor

@ucfunnel ucfunnel commented Dec 5, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

root and others added 30 commits June 5, 2017 05:43
2. Replace var with let
3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
@GLStephen
Copy link
Collaborator

@ucfunnel in the domains you changed one to .net and changed the other to https but did not change to .net, was that intended, or should both be changed to .net?

@GLStephen GLStephen self-assigned this Dec 5, 2019
@ucfunnel
Copy link
Contributor Author

ucfunnel commented Dec 5, 2019

We find some problem in the iframe cookie sync url, so we change the domain to .net .
The image cookie sync url is correct and change domain to https for the cookie samesite=none secure features.

Copy link
Collaborator

@GLStephen GLStephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the circleci failures appear unrelated

@GLStephen GLStephen added the LGTM label Dec 10, 2019
@idettman idettman merged commit 8c4039b into prebid:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants