-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ucfunnel adapter change cookie sync setting #4535
Conversation
2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
@ucfunnel in the domains you changed one to .net and changed the other to https but did not change to .net, was that intended, or should both be changed to .net? |
We find some problem in the iframe cookie sync url, so we change the domain to .net . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the circleci failures appear unrelated
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information