Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCPA / US privacy data support for LockerDome adapter #4575

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

margsliu
Copy link
Contributor

@margsliu margsliu commented Dec 11, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

These changes add CCPA / US privacy data support for the LockerDome adapter
Related docs PR: prebid/prebid.github.io#1669

gulp test results:

[10:04:45] Starting 'test'...
[10:04:45] Starting 'clean'...
[10:04:45] Finished 'clean' after 12 ms
[10:04:45] Starting 'lint'...
[10:05:03] Finished 'lint' after 18 s
[10:05:03] Starting 'test'...
START:
ℹ 「wdm」: 
ℹ 「wdm」: Compiled successfully.
ℹ 「wdm」: Compiling...
ℹ 「wdm」: 
ℹ 「wdm」: Compiled successfully.
11 12 2019 10:05:32.268:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9876/
11 12 2019 10:05:32.270:INFO [launcher]: Launching browsers ChromeHeadless with concurrency unlimited
11 12 2019 10:05:32.278:INFO [launcher]: Starting browser ChromeHeadless
11 12 2019 10:05:32.792:INFO [HeadlessChrome 78.0.3904 (Linux 0.0.0)]: Connected on socket S3C4Dmy5Dbq5q5mtAAAA with id 37132732
11 12 2019 10:05:34.068:WARN [web-server]: 404: /vuble_renderer.js
11 12 2019 10:05:36.017:WARN [web-server]: 404: /nurl&s=0.66
11 12 2019 10:05:36.017:WARN [web-server]: 404: /burl&s=0.66
11 12 2019 10:05:36.537:WARN [web-server]: 404: /scriptUrl.com
LOG: 'entrance', '5:36'
Finished in 5.522 secs / 2.888 secs @ 10:05:39 GMT-0600 (Central Standard Time)
SUMMARY:
✔ 4898 tests completed
ℹ 2 tests skipped
[10:05:39] Finished 'test' after 36 s
[10:05:39] Finished 'test' after 54 s```

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 367cd6f into prebid:master Dec 11, 2019
@margsliu
Copy link
Contributor Author

margsliu commented Dec 11, 2019

@jsnellbaker Hey, thanks! I also updated our wiki entry here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants