Update Sharethrough bid adapter endpoint #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `secure` parameter will equal `true` if the requesting page uses `https` and `false` otherwise Story: [#169736764](https://www.pivotaltracker.com/story/show/169736764)
harpere
approved these changes
Dec 12, 2019
|
conflicts resolved @harpere -- thanks for reviewing! |
|
hi, just following up on this @harpere. thanks! |
harpere
approved these changes
Dec 18, 2019
sa1omon
pushed a commit
to CleanMediaNet/Prebid.js
that referenced
this pull request
Dec 19, 2019
* Send parameter indicating the protocol of the requesting page - `secure` parameter will equal `true` if the requesting page uses `https` and `false` otherwise Story: [#169736764](https://www.pivotaltracker.com/story/show/169736764) * Add fallback logic to catch protocol of iframe when prebid does not reach window.top * Wrap location.protocol for testing; Add specs * Use only https butler endpoints in tests
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
* Send parameter indicating the protocol of the requesting page - `secure` parameter will equal `true` if the requesting page uses `https` and `false` otherwise Story: [#169736764](https://www.pivotaltracker.com/story/show/169736764) * Add fallback logic to catch protocol of iframe when prebid does not reach window.top * Wrap location.protocol for testing; Add specs * Use only https butler endpoints in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
https