-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DSPX adapter for PrebidJs 3.0 #4597
Fix DSPX adapter for PrebidJs 3.0 #4597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to missing comma, I'm unable to get test response
Here's the response I'm getting from the test parameters: Here's the request: |
@mike-chowla Fixed. Also I added an extra test. Could You try again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your test creative generates an error but I can see it's landing on the page so good enough for me.
Here's the creative coming back:
"adTag":"<script><p>111</p></script>
* Fix DSPX adapter for PrebidJs 3.0 * Fix dspxBidAdapter.md and add sending of DevMode flag to the server * add test for devMode Co-authored-by: avj83 <avj83@list.ru>
Type of change
Description of change
Fix DSPX adapter for Prebid JS 3.0. Also added
devMode
in adapter config