Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSPX adapter for PrebidJs 3.0 #4597

Merged
merged 3 commits into from
Dec 21, 2019

Conversation

onlsol
Copy link
Contributor

@onlsol onlsol commented Dec 14, 2019

Type of change

  • Other

Description of change

Fix DSPX adapter for Prebid JS 3.0. Also added devMode in adapter config

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to missing comma, I'm unable to get test response

modules/dspxBidAdapter.md Outdated Show resolved Hide resolved
@mike-chowla
Copy link
Contributor

Here's the response I'm getting from the test parameters:
{"reason":8003,"status":"delivery_disabled","msg":"delivery disabled by ConcheckConnect res_blacklist = 1; status_quickcheck = -1001","nbr":1,"info":{"code":0,"reason":8003,"message":"delivery disabled by ConcheckConnect res_blacklist = 1; status_quickcheck = -1001","placement_result":[],"campaign_result":[],"selection_result":[],"selection_transparency":[],"price_info":null}}

Here's the request:
GET /request/?_f=html&alternative=prebid_js&inventory_item_id=101&srw=300&srh=250&idt=100&rnd=52828309309&ref=http%253A%252F%252Fmike.pubmatic.com%253A9999%252FintegrationExamples%252Fgpt%252Fhello_world.html&bid_id=2a48e10cd523fc HTTP/1.1
Host: dcbuyer.dspx.tv
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache
Origin: http://mike.pubmatic.com:9999
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36
Content-Type: text/plain
Accept: /
Sec-Fetch-Site: cross-site
Sec-Fetch-Mode: cors
Referer: http://mike.pubmatic.com:9999/integrationExamples/gpt/hello_world.html
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cookie: buyer_idt=100; buyer_DID=0453e07c5846adf9e104d3f347f5c037'

@onlsol
Copy link
Contributor Author

onlsol commented Dec 20, 2019

@mike-chowla Fixed. Also I added an extra test. Could You try again?

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Your test creative generates an error but I can see it's landing on the page so good enough for me.

Here's the creative coming back:
"adTag":"<script><p>111</p></script>

@mike-chowla mike-chowla merged commit b923038 into prebid:master Dec 21, 2019
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* Fix DSPX adapter for PrebidJs 3.0

* Fix dspxBidAdapter.md and add sending of DevMode flag to the server

* add test for devMode

Co-authored-by: avj83 <avj83@list.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants