Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lkqdBidAdapter #4627

Merged
merged 14 commits into from
Jan 13, 2020
Merged

lkqdBidAdapter #4627

merged 14 commits into from
Jan 13, 2020

Conversation

mrcrawfo
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Added support for 'schain' ad request parameter
  • Fixed to read sizes from mediaTypes.banner.sizes in compliance with Prebid.js 3.0 release

@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2019

This pull request introduces 1 alert when merging 0b6f7cc into f765d65 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request introduces 1 alert when merging 8aad186 into b878aa9 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.js Outdated Show resolved Hide resolved
modules/lkqdBidAdapter.md Outdated Show resolved Hide resolved
@mrcrawfo mrcrawfo requested a review from msm0504 January 2, 2020 21:51
@msm0504 msm0504 merged commit ae820af into prebid:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants