Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR support added to the vuble bidder #4804

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Conversation

Roffray
Copy link
Contributor

@Roffray Roffray commented Jan 31, 2020

Type of change

  • Feature

Description of change

GDPR support added to the vuble bidder

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#1784

@Roffray Roffray changed the title GDPR support added to the bidder GDPR support added to the vuble bidder Jan 31, 2020
@Roffray
Copy link
Contributor Author

Roffray commented Jan 31, 2020

Is it possible to relaunch the tests ? They failed on another bid adapter after my last commit. (The tests where fine before that).

Thank you !

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@sumit116 sumit116 added LGTM and removed needs review labels Feb 5, 2020
@sumit116 sumit116 merged commit 50d2a29 into prebid:master Feb 5, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* Add: gdpr consent

* Del: comma

* Mod: properties names

* Check if gdpr applies is a boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants