Collect data about native + minor changes #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to pass dynamic parameters to adapter
Pass metadata from adapter
|
Seems like the ci/circleci tests fails every time a PR is made nowadays. I'm adding a comment to #4348 |
robertrmartinez
approved these changes
Feb 4, 2020
| @@ -60,6 +60,7 @@ let livewrappedAnalyticsAdapter = Object.assign(adapter({EMPTYURL, ANALYTICSTYPE | |||
| bidResponse.cpm = args.cpm; | |||
| bidResponse.ttr = args.timeToRespond; | |||
| bidResponse.readyToSend = 1; | |||
| bidResponse.mediaType = args.mediaType == 'native' ? 2 : 1; | |||
There was a problem hiding this comment.
args.mediaType == 'native' can probably use strict compare ===
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support collection of native analytics data (video not yet supported), setting endpoint of analytics call + some minor refactorings as suggested from previous PR.
The endpoint property is intended for internal use and is therefore not included in the documentation.