Fix failing circle-ci build job. #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fawke I see you deleted bunch of spec files. Is that intentional or by mistake ? We can't comment user id and prebid server adapter. Can you also add description related to the changes you are making |
|
Hi @jaiminpanchal27, It's intentional, but I don't want this PR to be merged, that's why I created a draft PR. I'm just testing the CI run by removing files which are throwing error. Later, I plan to analyse those files and see what's wrong. In the end, I won't delete any actual spec file if I do find an error, that'll be bad for our code coverage. I may report to the author of the spec file if I'm positive something needs to be changed in the file. |
…rowserstack-launcher to 1.4.0
Fawke
added
needs review
pinned
…erId_spec.js file
This was referenced Mar 15, 2020
jsnellbaker
approved these changes
Mar 16, 2020
jsnellbaker
added
needs 2nd review
robertrmartinez
approved these changes
Mar 17, 2020
bmwcmw
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Mar 31, 2020
* fix lint errors * update browser versions * remove problematic test cases * remove addtional files * fix errors in adagioBidAdapter.js and adagioBidAdapter_spec.js file * change karma config * change config * update timeout values * resolve merge conflict * -update karma\n-fix userIdSpec unit tests\n-update version of karma-browserstack-launcher to 1.4.0 * fix issue with userId_spec.js file * fix for realvu and sortable, potential fix for userId * resolve faulty merge * add a guideline to CONTRIBUGING.md and revert auction time back in userId_spec.js file
|
Still getting errors in RealVu-adapter https://circleci.com/gh/prebid/Prebid.js/7427?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* fix lint errors * update browser versions * remove problematic test cases * remove addtional files * fix errors in adagioBidAdapter.js and adagioBidAdapter_spec.js file * change karma config * change config * update timeout values * resolve merge conflict * -update karma\n-fix userIdSpec unit tests\n-update version of karma-browserstack-launcher to 1.4.0 * fix issue with userId_spec.js file * fix for realvu and sortable, potential fix for userId * resolve faulty merge * add a guideline to CONTRIBUGING.md and revert auction time back in userId_spec.js file
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* fix lint errors * update browser versions * remove problematic test cases * remove addtional files * fix errors in adagioBidAdapter.js and adagioBidAdapter_spec.js file * change karma config * change config * update timeout values * resolve merge conflict * -update karma\n-fix userIdSpec unit tests\n-update version of karma-browserstack-launcher to 1.4.0 * fix issue with userId_spec.js file * fix for realvu and sortable, potential fix for userId * resolve faulty merge * add a guideline to CONTRIBUGING.md and revert auction time back in userId_spec.js file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Circle CI has been failing lately more often than not. This PR attempts to fix that. Please note it only fixes circle-ci - build job and not the circle-ci - e2e job.
Related to: #4348
This PR fixes the following major issues:
karma-browserstack-laucherpackage to version1.4.0since there's an open issue in version1.5.0in which the tests time out. Click here for more details about the issue.karmaversion to the latest.browserDisconnectTimeout,browserNoActivityTimeout,captureTimeoutinkarma.conf.maker.jsto values recommended by Browserstack, which is 3e5.browserDisconnectToleranceto3from1. (Again recommended by Browserstack in case of weak connections.)5. (This means only 5 parallel sessions will run at a time in Browserstack. It's added because we don't want to put too many jobs on the queue which may result in timeouts.)adagioBidAdapter.jsfile by adding some error handling which has reduced the frequency of the following error,“Can't execute code from a freed script”. Also, fixes an error in adagio's test file which has reduced error in their file.realvuAnalyticsAdapter_spec.jsfile. The error originating from this file has gone down by quite a big margin.sortableAnalyticsAdapter_spec.js. Haven't tested this much.userId_spec.js. Raised a separate PR to fix since the bug was in the index.js file. User ID auctionDelay timeout bugfix #4982CONTRIBUTING.md.This PR also fixes the following minor issues:
browsers.jsonfilegulpfile.js